------ --------------------------------------------------------------------------
Line fillpdf.install
------ --------------------------------------------------------------------------
38 Call to deprecated method entityManager() of class Drupal:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
48 Call to deprecated method entityManager() of class Drupal:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------

------ ------------------------------------------------------------------------------------------------------
Line modules/fillpdf_legacy/src/Plugin/BackendService/LocalServerBackendService.php
------ ------------------------------------------------------------------------------------------------------
24 Class Drupal\fillpdf_legacy\Plugin\BackendService\LocalServerBackendService extends deprecated class
Drupal\fillpdf\Plugin\BackendServiceBase:
in fillpdf:8.x-4.9 and is removed from fillpdf:8.x-5.0.
Extend PdfBackendBase instead.
------ ------------------------------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------------------
Line modules/fillpdf_legacy/tests/Kernel/LegacyBackendTest.php
------ -----------------------------------------------------------------------------------------------------------------------------------
Class Drupal\Tests\fillpdf_legacy\Kernel\LegacyBackendTest was not found while trying to analyse it - autoloading is probably not
configured properly.
------ -----------------------------------------------------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------
Line src/Component/Utility/FillPdf.php
------ --------------------------------------------------------------------------
85 Call to deprecated function file_stream_wrapper_uri_normalize():
in drupal:8.8.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::normalizeUri()
instead.
------ --------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------
Line src/Form/FillPdfFormForm.php
------ -----------------------------------------------------------------------------------------------------------------------
191 Call to deprecated method l() of class Drupal\Core\Form\FormBase:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
261 Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
261 Call to deprecated constant FILE_MODIFY_PERMISSIONS: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::MODIFY_PERMISSIONS.
261 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
283 Call to deprecated method l() of class Drupal\Core\Form\FormBase:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
404 Call to deprecated method l() of class Drupal\Core\Form\FormBase:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
411 Call to deprecated method l() of class Drupal\Core\Form\FormBase:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
------ -----------------------------------------------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------
Line src/Form/FillPdfOverviewForm.php
------ -----------------------------------------------------------------------------------------------------------------------
103 Call to deprecated method l() of class Drupal\Core\Form\FormBase:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
119 Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
119 Call to deprecated constant FILE_MODIFY_PERMISSIONS: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::MODIFY_PERMISSIONS.
119 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
------ -----------------------------------------------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------
Line src/Form/FillPdfSettingsForm.php
------ -----------------------------------------------------------------------------------------------------------------------
370 Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
370 Call to deprecated constant FILE_MODIFY_PERMISSIONS: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::MODIFY_PERMISSIONS.
370 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
------ -----------------------------------------------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------
Line src/OutputHandler.php
------ -----------------------------------------------------------------------------------------------------------------------
78 Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
78 Call to deprecated constant FILE_MODIFY_PERMISSIONS: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::MODIFY_PERMISSIONS.
78 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
92 Call to deprecated constant FILE_EXISTS_RENAME: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::EXISTS_RENAME.
------ -----------------------------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------------------------
Line src/Plugin/PdfBackend/FillPdfServicePdfBackend.php
------ -------------------------------------------------------------------------------------------------
28 Class Drupal\fillpdf\Plugin\PdfBackend\FillPdfServicePdfBackend implements deprecated interface
Drupal\fillpdf\FillPdfBackendPluginInterface:
in fillpdf:8.x-4.9 and is removed from fillpdf:8.x-5.0.
Instead of implementing FillPdfBackendPluginInterface, you should extend
PdfBackendBase.
------ -------------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------
Line src/Plugin/PdfBackend/LocalServerPdfBackend.php
------ ----------------------------------------------------------------------------------------------
27 Class Drupal\fillpdf\Plugin\PdfBackend\LocalServerPdfBackend implements deprecated interface
Drupal\fillpdf\FillPdfBackendPluginInterface:
in fillpdf:8.x-4.9 and is removed from fillpdf:8.x-5.0.
Instead of implementing FillPdfBackendPluginInterface, you should extend
PdfBackendBase.
------ ----------------------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------------------------------------------
Line src/Plugin/PdfBackend/PdftkPdfBackend.php
------ ------------------------------------------------------------------------------------------------------------------
34 Class Drupal\fillpdf\Plugin\PdfBackend\PdftkPdfBackend implements deprecated interface
Drupal\fillpdf\FillPdfBackendPluginInterface:
in fillpdf:8.x-4.9 and is removed from fillpdf:8.x-5.0.
Instead of implementing FillPdfBackendPluginInterface, you should extend
PdfBackendBase.
218 Call to deprecated constant FILE_EXISTS_RENAME: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::EXISTS_RENAME.
------ ------------------------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------------------------------------------------
Line tests/modules/fillpdf_test/src/Plugin/BackendService/Test.php
------ -------------------------------------------------------------------------------------------------------------------------
16 Class Drupal\fillpdf_test\Plugin\BackendService\Test extends deprecated class Drupal\fillpdf\Plugin\BackendServiceBase:
in fillpdf:8.x-4.9 and is removed from fillpdf:8.x-5.0.
Extend PdfBackendBase instead.
38 Call to method __construct() of deprecated class Drupal\Component\Plugin\PluginBase:
in fillpdf:8.x-4.9 and is removed from fillpdf:8.x-5.0.
Extend PdfBackendBase instead.
------ -------------------------------------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------------
Line tests/modules/fillpdf_test/src/Plugin/FillPdfBackend/TestFillPdfBackend.php
------ ----------------------------------------------------------------------------------------------------
17 Class Drupal\fillpdf_test\Plugin\FillPdfBackend\TestFillPdfBackend implements deprecated interface
Drupal\fillpdf\FillPdfBackendPluginInterface:
in fillpdf:8.x-4.9 and is removed from fillpdf:8.x-5.0.
Instead of implementing FillPdfBackendPluginInterface, you should extend
PdfBackendBase.
------ ----------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------
Line tests/src/Functional/FillPdfFormDeleteFormTest.php
------ ---------------------------------------------------------------------------
Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
15 Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------

------ ---------------------------------------------------------------------------
Line tests/src/Functional/FillPdfFormDuplicateFormTest.php
------ ---------------------------------------------------------------------------
Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
15 Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------------
Line tests/src/Functional/FillPdfFormFormTest.php
------ ----------------------------------------------------------------------------------------------------
Class Drupal\Tests\fillpdf\Functional\FillPdfUploadTestBase not found and could not be autoloaded.
14 Class Drupal\Tests\fillpdf\Functional\FillPdfUploadTestBase not found and could not be autoloaded.
------ ----------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------
Line tests/src/Functional/FillPdfFormImportFormTest.php
------ ---------------------------------------------------------------------------
Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
13 Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------------
Line tests/src/Functional/FillPdfOverviewFormTest.php
------ ----------------------------------------------------------------------------------------------------
Class Drupal\Tests\fillpdf\Functional\FillPdfUploadTestBase not found and could not be autoloaded.
14 Class Drupal\Tests\fillpdf\Functional\FillPdfUploadTestBase not found and could not be autoloaded.
------ ----------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------
Line tests/src/Functional/FillPdfSettingsFormTest.php
------ ---------------------------------------------------------------------------
Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
13 Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------
Line tests/src/Functional/FillPdfTestBase.php
------ ---------------------------------------------------------------------------------------------
Class Drupal\Tests\file\Functional\FileFieldTestBase not found and could not be autoloaded.
13 Class Drupal\Tests\file\Functional\FileFieldTestBase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------
Line tests/src/Functional/FillPdfUploadTestBase.php
------ ----------------------------------------------------------------------------------------------
Class Drupal\Tests\fillpdf\Functional\FillPdfTestBase not found and could not be autoloaded.
16 Class Drupal\Tests\fillpdf\Functional\FillPdfTestBase not found and could not be autoloaded.
------ ----------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------------
Line tests/src/Functional/HandlePdfControllerTest.php
------ ----------------------------------------------------------------------------------------------------
Class Drupal\Tests\fillpdf\Functional\FillPdfUploadTestBase not found and could not be autoloaded.
19 Class Drupal\Tests\fillpdf\Functional\FillPdfUploadTestBase not found and could not be autoloaded.
------ ----------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------
Line tests/src/Functional/LinkManipulatorTest.php
------ ---------------------------------------------------------------------------
Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
16 Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------
Line tests/src/Functional/PdfParseTest.php
------ ----------------------------------------------------------------------------------------------
Class Drupal\Tests\fillpdf\Functional\FillPdfTestBase not found and could not be autoloaded.
16 Class Drupal\Tests\fillpdf\Functional\FillPdfTestBase not found and could not be autoloaded.
------ ----------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------
Line tests/src/Functional/PdfPopulationTest.php
------ ----------------------------------------------------------------------------------------------
Class Drupal\Tests\fillpdf\Functional\FillPdfTestBase not found and could not be autoloaded.
26 Class Drupal\Tests\fillpdf\Functional\FillPdfTestBase not found and could not be autoloaded.
------ ----------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------
Line tests/src/Functional/PdfWebformPopulationTest.php
------ ----------------------------------------------------------------------------------------------
Class Drupal\Tests\fillpdf\Functional\FillPdfTestBase not found and could not be autoloaded.
20 Class Drupal\Tests\fillpdf\Functional\FillPdfTestBase not found and could not be autoloaded.
------ ----------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------
Line tests/src/Functional/UninstallTest.php
------ ---------------------------------------------------------------------------
Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
14 Class Drupal\Tests\BrowserTestBase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------------------
Line tests/src/Kernel/FillPdfKernelTestBase.php
------ --------------------------------------------------------------------------------------------------
Class Drupal\KernelTests\Core\Entity\EntityKernelTestBase not found and could not be autoloaded.
10 Class Drupal\KernelTests\Core\Entity\EntityKernelTestBase not found and could not be autoloaded.
------ --------------------------------------------------------------------------------------------------

------ ------------------------------------------------------------------------
Line tests/src/Unit/FieldMapping/ImageFieldMappingTest.php
------ ------------------------------------------------------------------------
Class Drupal\Tests\UnitTestCase not found and could not be autoloaded.
12 Class Drupal\Tests\UnitTestCase not found and could not be autoloaded.
------ ------------------------------------------------------------------------

------ ------------------------------------------------------------------------
Line tests/src/Unit/FieldMapping/TextFieldMappingTest.php
------ ------------------------------------------------------------------------
Class Drupal\Tests\UnitTestCase not found and could not be autoloaded.
12 Class Drupal\Tests\UnitTestCase not found and could not be autoloaded.
------ ------------------------------------------------------------------------

------ ------------------------------------------------------------------------
Line tests/src/Unit/LinkManipulator/ParseBooleanFlagsTest.php
------ ------------------------------------------------------------------------
Class Drupal\Tests\UnitTestCase not found and could not be autoloaded.
13 Class Drupal\Tests\UnitTestCase not found and could not be autoloaded.
------ ------------------------------------------------------------------------

------ ------------------------------------------------------------------------
Line tests/src/Unit/LinkManipulator/ParseEntityIdsTest.php
------ ------------------------------------------------------------------------
Class Drupal\Tests\UnitTestCase not found and could not be autoloaded.
13 Class Drupal\Tests\UnitTestCase not found and could not be autoloaded.
------ ------------------------------------------------------------------------

------ ------------------------------------------------------------------------------------------------------------
Line xfdf.inc
------ ------------------------------------------------------------------------------------------------------------
43 Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use
\Drupal::time()->getRequestTime();
------ ------------------------------------------------------------------------------------------------------------

[ERROR] Found 69 errors

CommentFileSizeAuthor
#24 fillpdf_d9readiness_3114541_24.patch50.64 KBwizonesolutions
#14 fillpdf_deprecated_3114541_14.patch23.62 KBwizonesolutions
#12 fillpdf_deprecated_3114541_12.patch21.96 KBwizonesolutions
#7 deprecated-3114541-interdiff--2-7.txt12.21 KBandreyjan
#7 deprecated-3114541-7.patch16.5 KBandreyjan
#2 deprecated-3114541-2.patch10.3 KBpavnish

Comments

pavnish created an issue. See original summary.

pavnish’s picture

pavnish commented
StatusFileSize
new deprecated-3114541-2.patch10.3 KB

Adding Patch

pavnish’s picture

pavnish commented
Assigned: pavnish » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: deprecated-3114541-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

pavnish’s picture

pavnish commented
Status: Needs work » Needs review
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Needs work

No fixed patch was attached; back to Needs work.

andreyjan’s picture

andreyjan commented
Status: Needs work » Needs review
StatusFileSize
new deprecated-3114541-7.patch16.5 KB
new deprecated-3114541-interdiff--2-7.txt12.21 KB

Fixed failing test and removed remaining deprecations per Drupal 8.7.7. Also added core_version_requirement in the info.yml file.

There remain a few deprecations which depend on 8.8 which probably need to be fixed in a followup patch.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Re-testing, as Liam did a code cleanup which probably broke the patch. I'm going through this today and looking at it more closely. Some of the fixes, e.g. fixing internal deprecations in modules like fillpdf_legacy are probably inappropriate. I will just delete that module for the Drupal 9-compatible release (which will have to be a new branch anyway).

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Assigned: Unassigned » wizonesolutions
Status: Needs review » Needs work

Hmm, this is tricky. I would rather keep supporting supported versions of Drupal 8, but this patch already breaks 8.7.

So I'll just have to have a Drupal 9-specific version. That's because of deprecations, and it basically says as much on https://www.drupal.org/node/3070687

Most modules however will have to remove deprecated code to be compatible with Drupal 9. Therefore they will not able to be compatible with all versions of Drupal 8.

I think this module is sufficiently complex that I should make a new release version for Drupal 9 anyway. And I can switch to semantic versioning (5.0.0 instead of 8.x-5.0).

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Have been working with this. I started removing FillPDF-deprecated code in preparation for Drupal 9, but I actually also need to just clean up deprecations in the 8.x-4.x branch itself. That will make backporting new features easier. I will also try to support Drupal 8.8.3+ and Drupal 9 on the 5.0.x branch (which will have FillPDF's deprecations removed). New features will go there.

Steps remaining:

- re-run Upgrade Status/Drupal Rector in an 8.7.x environment and fix stuff
- make a new release based on that
- create a 5.0.x branch matching 8.x-1.x
- run Upgrade Status/Drupal Rector against it in a D9 environment
- fix everything up so tests pass
- release 5.0.0, which will be for Drupal 9 only (potentially also 8.9.0 until November 2021, since I can drop unsupported versions in a minor release, and they will have the same API anyway to start with)

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs work » Needs review
StatusFileSize
new fillpdf_deprecated_3114541_12.patch21.96 KB

OK. This should work for both 8.7 and 8.8. I'm not worried about beyond that. I will handle any issues with 8.9 or 9.0 in the new major branch. If this passes, I will issue the last major release for 8.x-4.x and open the 5.0.x development branch and focus on supporting as many releases as is practical (as well as removing deprecated FillPDF code).

Status: Needs review » Needs work

The last submitted patch, 12: fillpdf_deprecated_3114541_12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs work » Needs review
StatusFileSize
new fillpdf_deprecated_3114541_14.patch23.62 KB

OK, the same tests failed on every version, which is great. I think I've fixed them now.

One note is that this version will require at least 8.7.7. Given that 8.6 is no longer supported, and only the latest patch release of Drupal is supported at any one time, I think this is acceptable. If they use Composer for their sites, they won't be able to upgrade to a version that won't work, anyway.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Patch (to be ported)

Finally! Committed.

Did a manual spot check, and things looked OK there. Not that much of the guts of the module was changed, anyway.

Thanks for the patches, all!

I will now make the final 8.x-4.x release, cut the new branch, and work on Drupal 9 compatibility in this issue.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Assigned: wizonesolutions » Unassigned

Fixed coding standards issues. Checking that branch tests show them as fixed. Will pick up on this later this week or Monday.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Version: 8.x-4.x-dev » 5.0.x-dev
Status: Patch (to be ported) » Needs work

Here we gooooooo.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

5.0.x will not be compatible with Drupal 8.7 since support for that will end when Drupal 9 comes out. So I'm targeting latest 8.8.x and 9.0.0 beta.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Title: Drupal 9 Deprecated Code Report » Drupal 9 readiness
wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs work » Needs review
StatusFileSize
new fillpdf_d9readiness_3114541_24.patch50.64 KB

OK. Tests are passing locally. So here's a patch to remove the obvious old stuff like fillpdf_next and fillpdf_legacy. I'm not sure if it will pass against 9.0.0-beta3. Time to find out. Then I can go from there.

I have to set up tests, so I will add them manually.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Needs work

I will test this manually on D9. If it works, I will commit the composer.json change and upload an updated patch. That's what testbot is failing on.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs work » Needs review

I got tests working in both D8 and D9. I've committed the changes to 5.0.x, and I'm going to see if branch tests pass. If so, I will cut the first alpha release!

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Fixed

This is good enough. The branch tests fail because the Composer facade seems to lag behind the actual dev release visible on the project page. But tests pass locally. That's good enough.

I have not done manual testing yet, but I will do that before moving to beta releases. I have a number of style and API changes that I want to make before I have to start providing backwards compatibility (beta releases).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.