Drupal 9 compatibility for [Varbase Media Hero Slider] with Drupal coding standard and practice

drupal-check docroot/modules/contrib/varbase_heroslider_media

2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------- 
  Line   varbase_heroslider_media.install                                     
 ------ --------------------------------------------------------------------- 
  41     Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
 ------ --------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 1 error

Upgrade status

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Media Hero Slider 8.x-7.x-dev
Scanned on Thu, 02/13/2020 - 15:59.

1 warning found.

#3113214: Drupal 9 Readiness for [Varbse Media Hero Slider] with Drupal coding
standard and practice

modules/contrib/varbase_heroslider_media/varbase_heroslider_media.info.yml:
┌──────────┬──────┬─────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                         MESSAGE                         │
├──────────┼──────┼─────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to  │
│ manually │      │ varbase_heroslider_media.info.yml to designate that the │
│          │      │ module is compatible with Drupal 9. See                 │
│          │      │ https://www.drupal.org/node/3070687.                    │
│          │      │                                                         │
└──────────┴──────┴─────────────────────────────────────────────────────────┘

Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbse Media Hero Slider Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_heroslider_media/ --ignore=/var/www/html/products/varbase_heroslider_media/node_modules/

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_heroslider_media/ --ignore=/var/www/html/products/varbase_heroslider_media/node_modules/

Check Varbse Media Hero Slider Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_heroslider_media/ --ignore=/var/www/html/products/varbase_heroslider_media/node_modules/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_heroslider_media/ --ignore=/var/www/html/products/varbase_heroslider_media/node_modules/