drupal-check docroot/modules/contrib/varbase_styleguide

2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------- 
  Line   varbase_styleguide.install                                           
 ------ --------------------------------------------------------------------- 
  44     Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
 ------ --------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------- 
  Line   varbase_styleguide.module                                                                                          
 ------ ------------------------------------------------------------------------------------------------------------------- 
  28     Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use  
         \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.                                                             
 ------ ------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 2 errors


Upgrade status


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Varbase Styleguide 8.x-6.x-dev
Scanned on Thu, 02/13/2020 - 16:00.

1 warning found.

#3113192: Drupal 9 Readiness for [Varbase Styleguide] with Drupal coding
standard and practice

modules/contrib/varbase_styleguide/varbase_styleguide.info.yml:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to      │
│ manually │      │ varbase_styleguide.info.yml to designate that the module is │
│          │      │ compatible with Drupal 9. See                               │
│          │      │ https://www.drupal.org/node/3070687.                        │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘




Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbase Styleguide Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

Check Varbase Styleguide Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/





Showing style guide for Vartheme (Bootstrap 4 - SASS) PDF file

Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
harishkunta’s picture

Assigned: rajab natshah » harishkunta
rajab natshah’s picture

Assigned: harishkunta » rajab natshah

  • RajabNatshah committed ed74a4c on 8.x-6.x
    Issue #3113192: Drupal 9 Readiness for [Varbase Styleguide] with Drupal...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-8.8.4, +varbase-8.9.0, +varbase-9.0.0
StatusFileSize
new16.43 KB
rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/

rajab@vardot-dev:/var/www/html/products/varbase_styleguide$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/varbase_styleguide/ --ignore=/var/www/html/products/varbase_styleguide/node_modules/


rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes


Showing style guide for Vartheme (Bootstrap 4 - SASS) part 1Showing style guide for Vartheme (Bootstrap 4 - SASS) part 2Showing style guide for Vartheme (Bootstrap 4 - SASS) part 3Showing style guide for Vartheme (Bootstrap 4 - SASS) part 4
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue tags: -varbase-9.0.0 +varbase-9.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Title: Drupal 9 Readiness for [Varbase Styleguide] with Drupal coding standard and practice » Drupal 9 compatibility for [Varbase Styleguide] with Drupal coding standard and practice
Issue tags: -Drupal 9 readiness, -varbase-8.9.0
rajab natshah’s picture

Issue tags: +varbase-9.0.0-alpha1