Drupal 9 Deprecated Code Report for Components module

5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ --------------------------------------------------------------------------
Line src/Template/Loader/ComponentLibraryLoader.php
------ --------------------------------------------------------------------------
65 Call to deprecated function system_get_info():
in drupal:8.8.0 and is removed from drupal:9.0.0. Use
\Drupal::service('extension.list.$type')->getExtensionInfo() or
\Drupal::service('extension.list.$type')->getAllInstalledInfo() instead.
------ --------------------------------------------------------------------------

------ --------------------------------------------------------------
Line src/Template/TwigNodeTheme.php
------ --------------------------------------------------------------
29 Call to deprecated method getLine() of class Twig\Node\Node:
since 1.27 (to be removed in 2.0)
33 Call to deprecated method getLine() of class Twig\Node\Node:
since 1.27 (to be removed in 2.0)
------ --------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------
Line src/Template/TwigThemeTokenParser.php
------ ---------------------------------------------------------------------------------------------
21 Return type of method Drupal\components\Template\TwigThemeTokenParser::parse() has typehint
with deprecated interface Twig_NodeInterface:
since 1.12 (to be removed in 3.0)
------ ---------------------------------------------------------------------------------------------

[ERROR] Found 4 errors

Also, actually trying this on D9 will give you this error:

Warning: Declaration of Drupal\components\Template\Loader\ComponentsLoader::findTemplate($name) should be compatible with Twig\Loader\FilesystemLoader::findTemplate($name, $throw = true) in include() (line 444 of vendor/composer/ClassLoader.php). 

I'm not sure if #3 was on the 1.x branch, I'm not seeing any of that in 8.x-2.x.

The only thing I see is the twig method. I think the extra optional argument should be backward compatible and should work in D8 too.

Wasn't sure what to do about the docblock, copying it from the parent introduces a lot of drupal coding standard violations, so just went with the standard {@inheritdoc}

Thanks, looks good to me.

Also, RTBC by me.

Patch #5 works beautifully on D9 + 2.x-dev.

I'm having issues with D8 + 2.x-dev, I get a weird bug where I cannot use the administration theme (default remains active despite what's selected in the "Appearance" form). Note: I couldn't find the reason and it may not be related to this issue.

Committed!

@JohnAlbin, can we get a new beta or RC tagged so we have something to upgrade too? Maybe even update the Drupal 9 Compatibility Field for the project?