drupal-check janrain_capture/
21/21 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ -----------------------------------------------------------------------
Line src/RouteEnhancer.php
------ -----------------------------------------------------------------------
13 Class Drupal\janrain_capture\RouteEnhancer implements deprecated
interface Drupal\Core\Routing\Enhancer\RouteEnhancerInterface:
in drupal:8.4.0 and is removed from drupal:9.0.0. Instead,
you should use \Drupal\Core\Routing\EnhancerInterface.
See https://www.drupal.org/node/2894934
Part of the deprecation means that applies() is now called on runtime
instead
of compile time.
------ -----------------------------------------------------------------------

------ ---------------------------------------------------------------
Line tests/src/Functional/JanrainCaptureTest.php
------ ---------------------------------------------------------------
Class Drupal\Tests\BrowserTestBase not found and could not be
autoloaded.
------ ---------------------------------------------------------------

[ERROR] Found 2 errors

CommentFileSizeAuthor
#19 interdiff_15-19.txt431 bytesdivyesh19
#19 drupal_9_deprecated-3111278-19.patch5.42 KBdivyesh19
#15 interdiff_11-15.txt1.61 KBdivyesh19
#15 drupal_9_deprecated-3111278-15.patch5.39 KBdivyesh19
#11 interdiff_8-11.txt335 bytesdivyesh19
#11 drupal_9_deprecated-3111278-11.patch4.43 KBdivyesh19
#8 interdiff_3-8.txt1.88 KBdivyesh19
#8 drupal_9_deprecated-3111278-8.patch4.49 KBdivyesh19
#7 drupal_9_deprecated-3111278-7.patch4.11 KBdivyesh19
#4 interdiff_3-2.txt1.52 KBlilit_ghazaryan
#4 drupal_9_deprecated-3111278-3.patch2.4 KBlilit_ghazaryan
#2 drupal_9_deprecated_coed-3111278-2.patch698 bytesvigen.epam

Comments

Lilit_Ghazaryan created an issue. See original summary.

vigen.epam’s picture

vigen.epam commented
Assigned: lilit_ghazaryan » vigen.epam
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_coed-3111278-2.patch698 bytes

Status: Needs review » Needs work

The last submitted patch, 2: drupal_9_deprecated_coed-3111278-2.patch, failed testing. View results

lilit_ghazaryan’s picture

lilit_ghazaryan commented
StatusFileSize
new drupal_9_deprecated-3111278-3.patch2.4 KB
new interdiff_3-2.txt1.52 KB
lilit_ghazaryan’s picture

lilit_ghazaryan commented
Status: Needs work » Needs review
divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Assigned: vigen.epam » Unassigned
Status: Needs review » Needs work

As per the latest drupal-check results, we are getting following findings:

21/21 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -----------------------------------------------------------------------
  Line   src/RouteEnhancer.php
 ------ -----------------------------------------------------------------------
  13     Class Drupal\janrain_capture\RouteEnhancer implements deprecated
         interface Drupal\Core\Routing\Enhancer\RouteEnhancerInterface:
         in drupal:8.4.0 and is removed from drupal:9.0.0. Instead,
         you should use \Drupal\Core\Routing\EnhancerInterface.
         See https://www.drupal.org/node/2894934
         Part of the deprecation means that applies() is now called on runtime
         instead
         of compile time.
 ------ -----------------------------------------------------------------------

 ------ ----------------------------------------------------------------
  Line   src/ScreenLoaderManager.php
 ------ ----------------------------------------------------------------
  152    Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in
         drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
 ------ ----------------------------------------------------------------

 [ERROR] Found 2 errors
divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Assigned: Unassigned » divyesh19
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated-3111278-7.patch4.11 KB

Attaching updated patch.

divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
StatusFileSize
new drupal_9_deprecated-3111278-8.patch4.49 KB
new interdiff_3-8.txt1.88 KB

Updated patch.

divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Assigned: divyesh19 » Unassigned
Ravi_3596’s picture

Ravi_3596 commented
Status: Needs review » Reviewed & tested by the community

@divyesh19 - The patch #8 works for me too. It would be great if we can have it committed to dev.

divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
StatusFileSize
new drupal_9_deprecated-3111278-11.patch4.43 KB
new interdiff_8-11.txt335 bytes

Just fixing blank lines before committing this.

  • divyesh19 committed 596c53d on 8.x-1.x 
    Issue #3111278 by divyesh19, Lilit_Ghazaryan, vigen.epam, Ravi_3596:...
divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented

Thanks guys!

divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
StatusFileSize
new drupal_9_deprecated-3111278-15.patch5.39 KB
new interdiff_11-15.txt1.61 KB

Injecting datetime service instead of static call in Token.php.

divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Status: Fixed » Active

  • divyesh19 committed b6464f6 on 8.x-1.x 
    Issue #3111278 by divyesh19, Lilit_Ghazaryan, vigen.epam, Ravi_3596:...
divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
Status: Active » Fixed
divyesh19’s picture

divyesh19
his/him/he
Primary language English
commented
StatusFileSize
new drupal_9_deprecated-3111278-19.patch5.42 KB
new interdiff_15-19.txt431 bytes

Committing a fix in #15.

  • divyesh19 committed c879e2e on 8.x-1.x 
    Issue #3111278 by divyesh19, Lilit_Ghazaryan, vigen.epam, Ravi_3596:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.