Needs work
Project:
Commerce Vipps
Version:
8.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Feb 2020 at 13:32 UTC
Updated:
20 Jan 2021 at 11:16 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
twiik commentedPatch attached.
Comment #3
twiik commentedComment #4
zaporylieThis will only work if users are on the latest version of commerce_shipping module. Since commerce_shipping is in fact not required by vipps to work there's no dependency nor version constraint in composer.json, that we could use to enforce compatibility, Therefore I believe there must be an extra logic, a condition that will load either of 2 services depends on which version of commerce_shipping module is installed on the Drupal instance.
Comment #5
zaporylieI asked additional question in the parent issue #2996465: Put back adjustments to Shipments where the change was introduced, to confirm whether it's an API change that breaks BC and fix should be a part of commerce_shipping or the workaround must be added here.
Comment #6
zaporylieActually, it's Early and Late combined that are the replacement. But not a good replacemement in the same time because:
I need to find a better way of calculating Shipping VAT without triggering full order refresh. In the meantime - uploading combined Early and Late processors patch.