ShipmentOrderProcessor is removed and EarlyOrderProcessor and LateOrderProcessor is introduced in commerce_shipping 8.x-2.0-beta8. EarlyOrderProcessor looks like the direct replacement for the old ShipmentOrderProcessor so we should start using that instead.

CommentFileSizeAuthor
#6 3110783-6.patch3.44 KBzaporylie
#2 3110783-2.patch2.53 KBtwiik

Comments

TwiiK created an issue. See original summary.

twiik’s picture

StatusFileSize
new2.53 KB

Patch attached.

twiik’s picture

Status: Active » Needs review
zaporylie’s picture

Status: Needs review » Needs work

This will only work if users are on the latest version of commerce_shipping module. Since commerce_shipping is in fact not required by vipps to work there's no dependency nor version constraint in composer.json, that we could use to enforce compatibility, Therefore I believe there must be an extra logic, a condition that will load either of 2 services depends on which version of commerce_shipping module is installed on the Drupal instance.

zaporylie’s picture

I asked additional question in the parent issue #2996465: Put back adjustments to Shipments where the change was introduced, to confirm whether it's an API change that breaks BC and fix should be a part of commerce_shipping or the workaround must be added here.

zaporylie’s picture

Title: Change from ShipmentOrderProcessor to EarlyOrderProcessor » Remove ShipmentOrderProcessor usage
StatusFileSize
new3.44 KB

Actually, it's Early and Late combined that are the replacement. But not a good replacemement in the same time because:

  1. Order processors are not API and should be run like that
  2. VAT calculation for the shipping is missing

I need to find a better way of calculating Shipping VAT without triggering full order refresh. In the meantime - uploading combined Early and Late processors patch.

  • zaporylie committed f05bd97 on 8.x-4.x
    Issue #3110783 by TwiiK, zaporylie: Remove ShipmentOrderProcessor usage...