If something else tries to decorate the resource type repository, this module currently makes it impossible to support further decoration since it extends the base class and doesn't call the wrapped service.

CommentFileSizeAuthor
#10 3109870-9.patch8.16 KBmglaman
#8 3109870-8.patch7.41 KBmglaman
#7 3109870-7.patch8.04 KBmglaman
#6 3109870-6.patch9.26 KBmglaman
#5 3109870-5.patch7.9 KBmglaman
#4 3109870-4.patch7.35 KBmglaman
#2 3109870-2.patch7.23 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 3109870-2.patch7.23 KB

This seems to make it possible to decorate the core resource type repository and still use the cross bundles module.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 3109870-4.patch7.35 KB
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 3109870-5.patch7.9 KB
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 3109870-6.patch9.26 KB

Adding a patch which fixes unrelated public path rename, will split out into its own issue.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 3109870-7.patch8.04 KB

Rebased after #3078357: Cannot include relationships that aren't base fields.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 3109870-8.patch7.41 KB 
+++ b/src/ResourceType/CrossBundleResourceTypeRepository.php
@@ -3,14 +3,93 @@
+  /**
+   * {@inheritdoc}
+   *
+   * @todo fix regression from https://www.drupal.org/project/drupal/issues/3034786
+   */
+  public function getByTypeName($type_name) {
...
+  /**
+   * {@inheritdoc}
+   *
+   * @todo fix regression from https://www.drupal.org/project/drupal/issues/3034786
+   */
+  public function get($entity_type_id, $bundle) {

This isn't needed in this patch.

Status: Needs review » Needs work

The last submitted patch, 8: 3109870-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3109870-9.patch8.16 KB

Prime the resource types in the test.

  • mglaman committed d5ec002 on 8.x-1.x 
    Issue #3109870 by mglaman: Instead of extending the base class, call `...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.