Add the 'core_version_requirement' key in info.yml and composer.json files

CommentFileSizeAuthor
#16 3109188-16.patch1.05 KBneslee canil pinto
#12 3109188-5.patch1.05 KBankush_03
#6 3109188-4.patch583 bytesankush_03
#4 3109188-3.patch704 bytesankush_03
#2 3109188-2.patch701 bytesankush_03

Comments

ankushgautam76@gmail.com created an issue. See original summary.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3109188-2.patch701 bytes
ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Status: Active » Needs review
ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3109188-3.patch704 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

The composer.json change is no longer required, I'd recommend to leave that out.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3109188-4.patch583 bytes

@Berdir

Removed, Adding updated patch !

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Status: Needs work » Needs review
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented

Patch LGTM. +1 RTBC.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Status: Needs review » Reviewed & tested by the community
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

One small thing left for thest, when you run it with deprecations:

Remaining deprecation notices (1)

  1x: Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.
    1x in BlockClassTest::testBlockClass from Drupal\Tests\block_class\Functional
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: Unassigned » pratik_kamble
ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
StatusFileSize
new 3109188-5.patch1.05 KB

Added default theme variable!

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Assigned: pratik_kamble » Unassigned
Status: Needs work » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Ignore that test run, didn't see the 7.x-1.x. Looks good now to me.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch needs a reroll.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3109188-16.patch1.05 KB

Removed whitespace and rerolled the patch

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs review » Reviewed & tested by the community

LGTM

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Drupal 9 compatibility » Add core_version_requirement, fix test Drupal 9 computability issue, make a release
Issue tags: -Needs reroll +Drupal 9 porting day

Agree the patch looks good. I don't believe a reroll is needed anymore. It would be great to land this and make a release :) Exciting that the required changes are so few.

ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Title: Add core_version_requirement, fix test Drupal 9 computability issue, make a release » Add core_version_requirement, fix test Drupal 9 compatability issue, make a release
renatog’s picture

renatog commented

Makes sense

renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Committed to the dev branch.

Thank you all

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks to @RenatoG for tagging a new release for the #DrupalCares challenge! https://www.drupal.org/project/block_class/releases/8.x-1.2

UPDATED: Added an explicit task issue to update the project page with Drupal 9 info:

#3132573: Update project page with Drupal 9 information

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.