Drupal 9 Deprecated Code Report [#3109039]

Problem/Motivation

Discover if there are any problems when migrating to Drupal 9.

Proposed resolution

Running drupal-check against commit 95f167d gives:

./vendor/bin/drupal-check modules/contrib/recreate_block_content/
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------- 
  Line   recreate_block_content.module                      
 ------ --------------------------------------------------- 
  54     Call to deprecated function drupal_set_message().  
  56     Call to deprecated function drush_log().           
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 2 errors

Remaining tasks

Remove deprecated code.

Comment	File	Size	Author
#10	interdiff04-10.txt	413 bytes	edycarreyes99
#10	3109039-10.patch	413 bytes	edycarreyes99
#4	3109039-4.patch	696 bytes	ankush_03
#3	3109039-3.patch	695 bytes	ankush_03
#2	3109039-2.patch	569 bytes	john cook

Comments

Comment #1

26 January 2020 at 15:40

John Cook created an issue. See original summary.

Comment #2

john cook commented 26 January 2020 at 15:42

Status:	Active	» Needs review
Issue tags:		+ContributionWeekend2020

Status	File	Size
new	3109039-2.patch	569 bytes

I've uploaded a patch to replace the call to drupal_set_message().

But I'm unsure how to replace drush_log().

Comment #3

ankush_03

Gurgaon, India 🇮🇳

commented 27 January 2020 at 05:48

Status	File	Size
new	3109039-3.patch	695 bytes

Added updated patch !

Comment #4

ankush_03

Gurgaon, India 🇮🇳

commented 27 January 2020 at 05:50

Status	File	Size
new	3109039-4.patch	696 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	3109039-3.patch	695 bytes

Comment #5

joao sausen commented 18 March 2020 at 23:10

Thanks, I will be merging this on the next release.

Comment #6

19 March 2020 at 00:23

Joao Sausen committed f541e51 on 8.x-2.x

Issue #3109039 by john@johncook.me.uk,ankushgautam76@gmail.com: Drupal 9...

Comment #7

joao sausen commented 19 March 2020 at 00:30

This is merged on 8.x-2.x-dev

Comment #8

joao sausen commented 19 March 2020 at 00:31

Status:

Needs review

» Fixed

Comment #9

2 April 2020 at 00:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #10

edycarreyes99 commented 3 June 2020 at 04:23

Assigned:

Unassigned

» edycarreyes99

Status	File	Size
new	3109039-10.patch	413 bytes
new	interdiff04-10.txt	413 bytes

added core_version_requirement to the module.info.yml file

Drupal 9 Deprecated Code Report