It just took me a few minutes to figure out why I got the error "default.settings.php" should not be changed during installation.

I *moved* default.settings.php to settings.php that was my mistake. I think the error message could be nicer, I wondered what changes I had done to settings.php and it took me a while to get that the default file still has to be present.

CommentFileSizeAuthor
#9 default-settings-php-error-messag.png12.68 KBifrik
#3 3108803-3.patch856 bytesk4v

Comments

k4v created an issue. See original summary.

k4v’s picture

k4v commented
Issue tags: +GlobalContributionWeekend2020
k4v’s picture

k4v commented
StatusFileSize
new 3108803-3.patch856 bytes
k4v’s picture

k4v commented

"in any way" was a bit misleading, as the installer does not check the files content.

k4v’s picture

k4v commented
Status: Active » Needs review
k4v’s picture

k4v commented
Issue tags: +ContributionWeekend2020
gogowitsch’s picture

gogowitsch commented
Status: Needs review » Reviewed & tested by the community

My colleagues and I ran into this error multiple times for the same reason.

The patch looks fine to me. I tested it locally and the message is displayed correctly when using the HTTP-based installer.

c-logemann’s picture

c-logemann
he/him
Primary language German
Location Frankfurt/M, Germany
commented
Issue tags: -GlobalContributionWeekend2020

Removed tag "GlobalContributionWeekend2020" to reduce confusion. See global event page.

ifrik’s picture

ifrik
she/her
commented
Issue tags: +Usability, +ui-text
StatusFileSize
new default-settings-php-error-messag.png12.68 KB

Thanks kv4 for this UX fix - and for taking the time to fix an issue that developers won't even notice because once you know how it works you don't see the error messages anymore.

default.settings.php error message

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 8.9.0

Credited @ifrik and @Gogowitsch for testing the patch locally.

Committed and pushed f7d7c625f8 to 9.0.x and e6f3c8d035 to 8.9.x. Thanks!

  • alexpott committed f7d7c62 on 9.0.x 
    Issue #3108803 by k4v, ifrik, Gogowitsch: Error "default.settings.php...

  • alexpott committed e6f3c8d on 8.9.x 
    Issue #3108803 by k4v, ifrik, Gogowitsch: Error "default.settings.php...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.