Problem/Motivation

PHPCS reports the following errors that should be fixed:

FILE: /home/aleks/Projects/printemps/docroot/modules/custom/back_to_top/back_to_top.module
------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------
  12 | ERROR   | Doc comment is empty
  75 | WARNING | Line exceeds 80 characters; contains 87 characters
 104 | WARNING | Line exceeds 80 characters; contains 94 characters
 205 | WARNING | Line exceeds 80 characters; contains 126 characters
------------------------------------------------------------------------------------------


FILE: /home/aleks/Projects/printemps/docroot/modules/custom/back_to_top/src/Form/BackToTopSettingsForm.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------
  16 | ERROR   | Public method name "BackToTopSettingsForm::getFormID" is not in lowerCamel format
 149 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------------------------------------------

Proposed resolution

Fix codding standarts.

CommentFileSizeAuthor
#7 back_to_top-codingStandardFix-3107868-4-D8.patch2.59 KByugro
#7 back_to_top-codingStandardsFix-3107868-3-D8.patch2.59 KByugro
#6 back_to_top-codingStandardsFix-3107868-3-D8.patch0 bytesyugro
#5 back_to_top-codingStandardsFix-3107868-3-D8.patch0 bytesyugro
#4 codingStandardFix-3107868-2-D8.patch4.72 KByugro

Comments

id.aleks created an issue. See original summary.

yugro’s picture

yugro commented
Assigned: Unassigned » yugro
yugro’s picture

yugro commented
yugro’s picture

yugro commented
Assigned: yugro » Unassigned
Status: Active » Needs review
StatusFileSize
new codingStandardFix-3107868-2-D8.patch4.72 KB

Fixed coding standards in the mentioned files and tested

yugro’s picture

yugro commented
StatusFileSize
new back_to_top-codingStandardsFix-3107868-3-D8.patch0 bytes

fixed coding standards in the described files and tested them

yugro’s picture

yugro commented
StatusFileSize
new back_to_top-codingStandardsFix-3107868-3-D8.patch0 bytes

fixed coding standards in the described files and tested them

yugro’s picture

yugro commented
StatusFileSize
new back_to_top-codingStandardsFix-3107868-3-D8.patch2.59 KB
new back_to_top-codingStandardFix-3107868-4-D8.patch2.59 KB

fixed and tested coding Standards in listed files

yugro’s picture

yugro commented
id.aleks’s picture

id.aleks commented
Status: Needs review » Reviewed & tested by the community

back_to_top-codingStandardFix-3107868-4-D8.patch lloks good for me.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

  • acke committed 3b84e33 on 2.x authored by yugro 
    Issue #3107868 by yugro: Fix coding standards
acke’s picture

acke commented
Status: Needs review » Fixed

Fixed in the 2.0.0 release. Thanks for help and patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.