Problem/Motivation

This module is currently not 100% D9 compatible.

Proposed resolution

- Add defaultTheme in tests
- Add core_version_requirement in info.yml

CommentFileSizeAuthor
#2 3106255.patch1.13 KBchr.fritsch
#6 3106255-6.patch1.1 KBchr.fritsch

Comments

chr.fritsch created an issue. See original summary.

chr.fritsch’s picture

Status: Active » Needs review
StatusFileSize
new1.13 KB

Here you go

hchonov’s picture

Thanks, but actually there is no need to limit the module only to 8.7.7 and D9.

core_version_requirement: ^8 || ^9 is sufficient.

I can change that on commit if that is fine with you.

chr.fritsch’s picture

I am ok with that 👍

hchonov’s picture

as this discussed in Slack right now this should further limit D8 to >= 8.3.

We could solve it similar to #3096615: Make Drupal 9 ready and remove deprecated code usages;

+++ b/prefetch_cache.info.yml
@@ -2,5 +2,7 @@ name: Prefetch Cache
 core: 8.x
+core_version_requirement: ^8 || ^9
 dependencies:
+  - drupal:system (>= 8.3)

Will change it on commit.

chr.fritsch’s picture

StatusFileSize
new1.1 KB

Quickly fixed it

  • hchonov committed de692cd on 8.x-1.x authored by chr.fritsch
    Issue #3106255 by chr.fritsch, hchonov: Make module D9 compatible
    
hchonov’s picture

Status: Needs review » Fixed

Committed and pushed to 8.x-1.x. Thank you!

chr.fritsch’s picture

Cool. And now release it 😎

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.