Nested form sometimes saves the same entity twice, WSOD

My gut feeling is that this one is a duplicate of the other issue. Can you check if with the other fix you can reproduce your problem?

> Just to be sure, do you want me to try the patch on comment #141?

Yes.

Thanks that you cross-checked this is not the same.
I assume this did not change on dev (please always check and file against dev in the future).

This is really a strange thing. Let's re-phrase and guess a bit: So this happens when you "create, save, edit, save" an IEF child entity in the UI, and somehow IEF internally memorizes it should save twice which leads to errors.

While the patch may solve the problem, it does not go to the root. Questions:
a) If the above is correct, the error can be reproduced mush simpler. Is this correct? What is the simplest form to reproduce it?
b) If the above is correct, where is the place IEF internally saves the entity twice (i guess into $formState), so we can fix that?

Can you wirte a failing test for a)?

We have a nested entity structure and we are using IEF to create/edit these entities. We are intermittently seeing this error; About 1 out of every 5 times.

We are on Drupal 8.8.10 and IEF version 1.0.0-rc7.

Parent entity has 2 entity reference fields; Create one entity reference. That entity has another field to link to an existing or create a new entity. Create a new reference. Therefore you have created 3 nested entities. When you save, you get a fatal error

Integrity constraint violation: 1062 Duplicate entry 'ab497f6c-4bf2-4b72-b053-30d170b2f0b0' for key 'entity_field_uuid_value'

I will check trying this patch sometime soon.

Stacey

Just leaving a note that we're seeing this error as well. The patch seems to prevent the error.

In case it helps anyone, here is a generalized description of how to consistently reproduce the error:

Assuming this structure of nested entities:
Parent entity > child entity > grandchild entity

Steps to reproduce:
1.) Create/edit a parent entity.
2.) Create a new child entity. Add a grandchild entity to it. Click the ‘Create [child entity]’ button.
3.) Before saving the parent entity, re-edit the child entity and add another grandchild to it. Click the ‘Update [child entity]’ button.
4.) Then save the parent entity. The fatal error occurs.

Hi, we were getting the same error but with "heavy" nested taxonomy terms. In our case we have 4 levels (!):
- Node: parent entity --> Using Inline entity form.
-- Entity Reference to Media: child entity
--- Entity Reference to Node: grand-child entity
---- Entity Reference to Taxonomy Term: great-grand-child

Applied the patch provided in #2 and I can confirm it solves the issue, no fatal error thrown for "Duplicate Entry".

What needs to be done in order to make this RTBC?

Thanks!
m

After applying the suggested patch, some php notices started to appear in our log messages.

Notice: Undefined index: #field_name in inline_entity_form_open_form() (line 209 of inline_entity_form.module)

Also, some users complain that when the hit the "Add more" button, a new form doesn't open and the inline form becomes useless. They need to refresh their page. Not sure, if these two related.

Also, both the log file and the "Add more" button not opening happen rarely, not sure how to reproduce this...

I've created a failing test for this one.

This seems to only happen when there's at least one parent->child->grandchild in play (so triple nested).
I couldn't reproduce it with only parent->child relations as suggested by @geek-merlin here:

This is really a strange thing. Let's re-phrase and guess a bit: So this happens when you "create, save, edit, save" an IEF child entity in the UI, and somehow IEF internally memorizes it should save twice which leads to errors.

The minimal steps to reproduce this error are (at least for me) described here by @maursilveira:

(Note: First create a node that holds the parent)

1. Create parent
2. Create first child (entity reference in the parent)
3. Save first child
4. Save parent
5. Edit parent
6. Create second child
7. Save second child
8. Save parent
9. Save main node.

Although patch #2 does make the newly added failing test pass, I'm keeping this at Needs work.

The comments in #12 seem to point out that "somehow sometimes" this patch is un-setting too much.

Notice: Undefined index: #field_name in inline_entity_form_open_form() (line 209 of inline_entity_form.module)

Also, some users complain that when the hit the "Add more" button, a new form doesn't open and the inline form becomes useless. They need to refresh their page.

I think we should try to look a bit deeper into the root cause of this one.
Looking at @geek-merlin... 😇

EDIT: As already excellently "Sherlocked" in #8 when the node isn't saved before adding a new child to a parent the first (and most probably n-th child when adding a n+1-th child through editing the parent before saving the node) is marked as `needs_save` more than once.

Patch #2 does house-keeping on doSave to try to repair it all, but I think we should "somehow" prevent the n-th child from becoming marked as `needs_save`.

Intermittently looking into that, but I've seem to become too much specialized in writing tests for IEF to immediately grok it's actually logic.

If anybody sees where it all falls down: Please help :)

@Spokje: Thanks for soft-pinging me. Unfortunately i have the same concerns about this concerning our saving-nested-entities code that i voiced in the related issue... Still thinking...

I've modified a little bit the patch from #2 to unset the needs_save flag of a duplicate entity (based on uuid) instead of unsetting the entity itself, which was probably causing the warnings described in #12.

Since I have never experienced again with the ief code, the idea of unsetting the needs_save flag was based on #14 EDIT comment.
Not sure if this is the best way to handle it, but the issue seems to be resolved, although it doesn't solve the root cause of the issue.

#16 patch no working for me

Same error with a new duplicate entry

Drupal\Core\Entity\EntityStorageException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'a173f321-119a-45b3-9990-55cc7e9bd58f' for key 'node_field__uuid__value': INSERT INTO {node} ("vid", "type", "uuid", "langcode") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3); Array ( [:db_insert_placeholder_0] => [:db_insert_placeholder_1] => news [:db_insert_placeholder_2] => a173f321-119a-45b3-9990-55cc7e9bd58f [:db_insert_placeholder_3] => zxx ) in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 810 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Drupal\Core\Database\StatementWrapper->execute(Array, Array) (Line: 823)
Drupal\Core\Database\Connection->query('INSERT INTO {node} ("vid", "type", "uuid", "langcode") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3)', Array, Array) (Line: 97)
Drupal\Core\Database\Driver\mysql\Connection->query('INSERT INTO {node} ("vid", "type", "uuid", "langcode") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3)', Array, Array) (Line: 32)
Drupal\Core\Database\Driver\mysql\Insert->execute() (Line: 937)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->doSaveFieldItems(Object) (Line: 622)
Drupal\Core\Entity\ContentEntityStorageBase->doSave(NULL, Object) (Line: 452)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 801)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 339)
Drupal\Core\Entity\EntityBase->save() (Line: 260)

We now have multiple "dragons in nested IEFs" issues...

OK, 57c5 successfully triggered the exception. Let's see if this is green.

Banzai! We provoked the multiple-child variant of the bug**.

OK, and now the improved fix.

Finally all green, mustfail is red. So ready.