At some point it looks like core's CKEditor switched to using iframes by default. This means that when the add_css AJAX command runs, the additional CSS gets added to the root document's head, and not the CKEditor iframe's head, so the styles don't actually load in the editor.

CommentFileSizeAuthor
#6 3097116-provide-plain-html-preview.patch3.6 KBDave Reid
#4 3097116-provide-plain-html-preview.patch3.14 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid created an issue. See original summary.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented

It doesn't seem possible to add CSS to the WYSIWYG dynamically from the plugin JS. It does look like this would be possible with CKEditor.editor.addContentsCss(), which is available as of v4.4+, but with D8 we're only using 4.11.4 as the latest version. :(

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Related issues: +#956186: Allow AJAX to use GET requests
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
FileSize
3097116-provide-plain-html-preview.patch3.14 KB

For now let's provide a simpler preview if the request is a normal GET request.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Status: Active » Needs review
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
FileSize
3097116-provide-plain-html-preview.patch3.6 KB

Try to fix the test

  • Dave Reid committed fe55fa9 on 8.x-1.x 
    Issue #3097116 by Dave Reid: Allow the embed preview route to return a...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Status: Needs review » Needs work

Marking back to needs work for now.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Title: Preview controller and AJAX method no longer work to add CSS to CKEditor iframes » Preview controller and AJAX method no longer work to add CSS or JS to CKEditor iframes

I wonder if this is worth revisiting to see if we could also solve this for JS assets as well with https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_scriptLoader.html