When I hover on the 'Register' link it says "Add a registration link to the user menu. Displayed for administrators and anonymous users".

I don't think it should say that to anonymous users.

CommentFileSizeAuthor
#2 3096584-2.patch627 bytessahana _n

Comments

effortDee created an issue. See original summary.

sahana _n’s picture

sahana _n commented
Status: Active » Needs review
StatusFileSize
new 3096584-2.patch627 bytes

Please review the patch.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: Unassigned » i-trokhanenko

I'll check #2

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Needs review » Needs work

getting notice after applying patch 2 (see blockquote), need to add a few conditions, also coding standards a missed

Notice: Undefined index: registration_link.user_register in registration_link_preprocess_menu() (line 36 of /var/www/d8_8/web/modules/custom/registration_link/registration_link.module) #0 /var/www/d8_8/web/core/includes/bootstrap.inc(596): _drupal_error_handler_real(8, 'Undefined index...', '/var/www/d8_8/w...', 36, Array) #1 /var/www/d8_8/web/modules/custom/registration_link/registration_link.module(36): _drupal_error_handler(8, 'Undefined index...', '/var/www/d8_8/w...', 36, Array) #2 /var/www/d8_8/web/core/lib/Drupal/Core/Theme/ThemeManager.php(287): registration_link_preprocess_menu(Array, 'menu__toolbar', Array)

  • i-trokhanenko committed d429bd3 on 8.x-2.x 
    Issue #3096584 by Sahana _N, i-trokhanenko, effortDee: Hovering on the...
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: i-trokhanenko » Unassigned
Status: Needs work » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.