Problem/Motivation

We should add defaultTheme where it will be required in tests extending BrowserTestBase.

Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/2352949, which includes recommendations on which theme to use.

See https://www.drupal.org/node/3083055
and https://www.drupal.org/project/drupal/issues/3082655

Proposed resolution

Add the defaultTheme property to tests that extend BrowserTestBase, where appropriate or another theme where appropriate, based on https://www.drupal.org/node/3083055

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3095642-2.patch517 bytesrpayanm

Comments

oknate created an issue. See original summary.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 3095642-2.patch517 bytes
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Looking good.

  • amaria committed 493bad1 on 8.x-1.x authored by rpayanm 
    Issue #3095642 by rpayanm: Add defaultTheme in tests extending...
amaria’s picture

amaria commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.