Problem/Motivation

@ojchris37 reported in #3091300: The right URL when root is Subfolder that the tab http://sitemy.com/web/admin/config/people/agreement/agreements does not indicate what user has accepted the terms with a good marker, everything remains X.

There isn't a functional test for this behavior so at the very least a functional test should be added to confirm that this is functional (or non-functional).

Proposed resolution

Remaining tasks

Comments

mradcliffe created an issue. See original summary.

mradcliffe’s picture

Status: Active » Needs review
StatusFileSize
new1.28 KB

Here's a test.

mradcliffe’s picture

I haven't been able to confirm this with manual testing.

The agreement record views page with two rows. One for user 'blah' that has agreed and shows a check mark. The other for user 'admin' who has not agreed and shows a X

ojchris’s picture

Thanks for the follow up on https://www.drupal.org/project/agreement/issues/3091300 and the fix. Pity I couldn't get to respond as quickly as it should. Had other battles.

CONTEXT
======
On this new issue, the marker worked previously on my local setup where my virtual host setting ensured the based URL was mysite.com and not mysite.com/projectfolder/web. On the server because it was in a subfolder at the time couldn't even test the workings base on the issue reported here https://www.drupal.org/project/agreement/issues/3091300.

But after applying the patch there, everything works fine but the marker does not register. Hope this useful. Thank you.

mradcliffe’s picture

StatusFileSize
new1.29 KB

I think one thing you might want to try is to change the Agreement Records view from the Views user interface. You should be able to do this, if you have the core Views UI module enabled, by going to Administration > Structure > Views. Then you should be able to Edit the Agreements view.

These views are "optional" and it is our intention that you can create your own or modify for your own needs. The current view has the Views field "Agreed" configured to use the Yes-No checkmark. The Views module also provides different options for this. You could try choosing one of those. The checkmark does require a unicode font that supports those values.

Please ignore the patch that I uploaded as it is only a functional test to cover the Agreement Records page.

mradcliffe’s picture

StatusFileSize
new1.26 KB

  • mradcliffe committed d9dff24 on 8.x-2.x
    Issue #3094948 by mradcliffe: Adds functional test to assert admin view
    
ojchris’s picture

Without applying the patch in #6 I just logged in now to noticed the marker has registered as expected. Seems like what I experienced was a cache issue. Guess we mark this as fixed, what do you think?

mradcliffe’s picture

Status: Needs review » Fixed

Yes. I can't reproduce this. The patch is only a functional test that adds for regression testing this feature.

Thank you for confirming that it's probably a cache issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.