php drupal-check.phar modules/contrib/background_image/
 30/30 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------- 
  Line   src/BackgroundImageManager.php                                  
 ------ ---------------------------------------------------------------- 
  201    Call to deprecated function file_unmanaged_delete_recursive().  
 ------ ---------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------- 
  Line   src/Controller/BackgroundImageCssController.php                                
 ------ ------------------------------------------------------------------------------- 
  122    Call to deprecated function drupal_dirname().                                  
  123    Call to deprecated function file_prepare_directory().                          
  198    Call to deprecated method substr() of class Drupal\Component\Utility\Unicode.  
  237    Call to deprecated function file_prepare_directory().                          
  238    Call to deprecated function file_unmanaged_save_data().                        
  243    Call to deprecated function file_unmanaged_save_data().                        
  301    Call to deprecated function file_stream_wrapper_valid_scheme().                
 ------ ------------------------------------------------------------------------------- 

 ------ ------------------------------------------------ 
  Line   src/Entity/BackgroundImage.php                  
 ------ ------------------------------------------------ 
  631    Call to deprecated method l() of class Drupal.  
 ------ ------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   src/Form/BackgroundImageForm.php                   
 ------ --------------------------------------------------- 
  799    Call to deprecated function drupal_set_message().  
  802    Call to deprecated function drupal_set_message().  
  859    Call to deprecated function drupal_set_message().  
  864    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 13 errors
CommentFileSizeAuthor
#6 3092133-6.patch16.48 KBmarkhalliwell
#3 interdiff.txt2.81 KBbasvredeling
#3 background_image-3092133-3.patch9.46 KBbasvredeling
#2 deprecated-3092133-2.patch8.71 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3092133-2.patch8.71 KB

Here's the patch, please review.

basvredeling’s picture

basvredeling
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new background_image-3092133-3.patch9.46 KB
new interdiff.txt2.81 KB

#2 looks mostly good. I've added a few missing deprecation fixes and changed the order of the use statements to be alphabetical.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 8.x-1.x-dev » 2.x-dev
Assigned: Unassigned » markhalliwell
Status: Needs review » Needs work
markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: Deprecated Code Report » [background_image] Drupal 9
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: markhalliwell » Unassigned
Status: Needs work » Fixed
StatusFileSize
new 3092133-6.patch16.48 KB

  • markcarver committed d739056 on 2.x 
    Issue #3092133 by markcarver, basvredeling, Sergiu Stici: [...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.