Problem/Motivation

Background media not covering the content in appropriate way as it appear scaled up and not centered, this issue appear for all types (image, remote video, local video).

Proposed resolution

Using CSS object-fit property to specify how an <img> or <video> should be resized to fit its container. This property tells the content to fill the container in a variety of ways; such as "preserve that aspect ratio" or "stretch up and take up as much space as possible".

Also, it's better to use object-fit-polyfill (polyfill for browsers that don't support the object-fit CSS property) for old browsers as it supports IE 9+, iOS 7-, and Android 4.4.

Test Varbase Media Header page - Image

Test Varbase Media Header page - Image
Click to watch the video

Test Varbase Media Header page - Local Video

Test Varbase Media Header page - Local Video
Click to watch the video

Test Varbase Media Header page - Remote Video Vimeo

Test Varbase Media Header page - Remote Video Vimeo
Click to watch the video

Test Varbase Media Header page - Remote Video Youtube

Test Varbase Media Header page - Remote Video Youtube
Click to watch the video

Test Varbase Media Header page - Standard

Test Varbase Media Header page - Standard

Click to watch the video

Test Varbase Media Header page - Media Header but no media

Test Varbase Media Header page - Media Header but no media

Click to watch the video


Tablet sizes


Mobile sizes

CommentFileSizeAuthor
#13 Test-Varbase-Media-Header-page-Standard-dev-varbase8c1-xs.png118.39 KBrajab natshah
#13 Test-Varbase-Media-Header-page-Media-Header-but-no-media-dev-varbase8c1-xs.png82.61 KBrajab natshah
#13 Test-Varbase-Media-Header-page-Remote-Video-Youtube-dev-varbase8c1-xs.png187.49 KBrajab natshah
#13 Test-Varbase-Media-Header-page-Remote-Video-Vimeo-dev-varbase8c1-xs.png183.95 KBrajab natshah
#13 Test-Varbase-Media-Header-page-Local-Video-dev-varbase8c1-xs.png292.39 KBrajab natshah
#13 Test-Varbase-Media-Header-page-Image-dev-varbase8c1-xs.png234.22 KBrajab natshah
#12 Test-Varbase-Media-Header-page-Media-Header-but-no-media-dev-varbase8c1-sm-md.png194.13 KBrajab natshah
#12 Test-Varbase-Media-Header-page-Standard-dev-varbase8c1-sm-md.png227.16 KBrajab natshah
#12 Test-Varbase-Media-Header-page-Remote-Video-Youtube-dev-varbase8c1-sm-md.png459.04 KBrajab natshah
#12 Test-Varbase-Media-Header-page-Remote-Video-Vimeo-dev-varbase8c1-sm-md.png466.29 KBrajab natshah
#12 Test-Varbase-Media-Header-page-Local-Video-dev-varbase8c1-sm-md.png807.31 KBrajab natshah
#12 Test-Varbase-Media-Header-page-Image-dev-varbase8c1-sm-md.png748.63 KBrajab natshah
#9 Test Varbase Media Header page - Media Header but no media - only background color - sizes.gif14.29 MBrajab natshah
#9 Test Varbase Media Header page - Standard - sizes.gif9.67 MBrajab natshah
#9 Test Varbase Media Header page - Remote Video Youtube - sizes.gif32.94 MBrajab natshah
#9 Test Varbase Media Header page - Remote Video Vimeo - sizes.gif31.98 MBrajab natshah
#9 Test Varbase Media Header page - Local Video - sizes.gif47.02 MBrajab natshah
#9 Test Varbase Media Header page - Image - sizes.gif25.29 MBrajab natshah
#8 Test-Varbase-Media-Header-page-Media-Header-but-no-media-dev-varbase8c1-lg-xl.png271.06 KBrajab natshah
#8 Test-Varbase-Media-Header-page-Standard-dev-varbase8c1-lg-xl.png267.54 KBrajab natshah
#8 Test-Varbase-Media-Header-page-Remote-Video-Youtube-dev-varbase8c1-lg-xl.png655.16 KBrajab natshah
#8 Test-Varbase-Media-Header-page-Remote-Video-Vimeo-dev-varbase8c1-lg-xl.png711.4 KBrajab natshah
#8 Test-Varbase-Media-Header-page-Local-Video-dev-varbase8c1-lg-xl.png1.25 MBrajab natshah
#8 Test-Varbase-Media-Header-page-Image-dev-varbase8c1-lg-xl.png1.16 MBrajab natshah

Comments

Odai Atieh created an issue. See original summary.

rajab natshah’s picture

Title: Fix background media supports for IE 9+, iOS 7-, and Android 4.4 (Image, Video, Video, YouTube, Vimeo) Object-fit » Fix background media supports in [Varbase Media Header] for IE 9+, iOS 7-, and Android 4.4 (Image, Video, Video, YouTube, Vimeo) Object-fit
rajab natshah’s picture

Assigned: Unassigned » rajab natshah

  • RajabNatshah committed 87e0fdf on 8.x-7.x
    Issue #3090778: Fix background media supports in [Varbase Media Header]...

  • RajabNatshah committed 358b381 on 8.x-7.x
    Issue #3090778: Fix background media supports in [Varbase Media Header]...
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.8.7, +varbase-9.0.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.