Problem/Motivation

Be ready for Drupal 9.

Proposed resolution

  • [ ] Create a patch which follow the Gabor documentation: http://hojtsy.hu/blog/2018-dec-17/how-automate-testing-whether-your-drup... to expose potential code flaws
  • [ ] Test the module using umami and the Upgrade Status module
  • [ ] Add drupal-check as a dev-dependency, update the DEVELOPPING.md file (section [## 🚔 Check Drupal coding (...) practices) with the new drupal-check feature, update the scripts/hooks/post-commit file with the drupal-check command

Remaining tasks

CommentFileSizeAuthor
#12 interdiff-3090756-11-12.txt3.55 KBwengerk
#12 3090756-12.patch12.98 KBwengerk
#11 3090756-11.patch9.31 KBwengerk
#11 interdiff-3090756-10-11.txt709 byteswengerk
#10 3090756-10.patch8.44 KBwengerk
#10 interdiff-3090756-07-10.txt386 byteswengerk
#7 3090756-07.patch7.79 KBwengerk
#6 3090756-06.patch7.79 KBwengerk
#5 3090756-05.patch7.31 KBwengerk
#4 3090756-04.patch8.7 KBwengerk
#2 3090756-02.patch576 byteswengerk

Comments

wengerk created an issue. See original summary.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Status: Active » Needs review
StatusFileSize
new 3090756-02.patch576 bytes

Let's test the patch

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Issue summary: View changes
wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090756-04.patch8.7 KB

Let's try this patch, made many changes so it may break tests ...

This patch will force Template Whisperer to be used on Drupal 8.9+ so we will not be able to merge it soon, maybe a 9.x branch should be created.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090756-05.patch7.31 KB

... some changes about pagers and TemplateWhispererSuggestionListBuilder

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090756-06.patch7.79 KB

adding the core_version_requirement key for Drupal 9

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090756-07.patch7.79 KB

remove the core key as required when using core_version_requirement for ^8.8

anu.a_95’s picture

anu.a_95 commented
Issue tags: +GlobalContributionWeekend2020

Patch applied successfully. The patch fixes the below 2 errors which were thrown up without the patch

88 Call to deprecated function pager_default_initialize():
in drupal:8.8.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Pager\PagerManagerInterface->defaultInitialize() instead.
108 Call to deprecated method url() of class
Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Please use toUrl() instead.

8 other errors like some test case missing was thrown up with and without patch.

c-logemann’s picture

c-logemann
he/him
Primary language German
Location Frankfurt/M, Germany
commented
Issue tags: -GlobalContributionWeekend2020 +ContributionWeekend2020

"ContributionWeekend2020“ is the "official" tag suggested on global event page.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new interdiff-3090756-07-10.txt386 bytes
new 3090756-10.patch8.44 KB

Here a patch to fix the defaultTheme Drupal 9 requirement for Functional Testing.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new interdiff-3090756-10-11.txt709 bytes
new 3090756-11.patch9.31 KB

Use stark them instead of class on functional UI tests to use links.action.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
StatusFileSize
new 3090756-12.patch12.98 KB
new interdiff-3090756-11-12.txt3.55 KB

last version with explanation of versions in README.md.

  • wengerk authored 6b24c29 on 8.x-3.x 
    Issue #3090756 by wengerk: Drupal 9 Readiness
wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.