8.x-1.0-alpha6 made the module always insert the script for the auto blocking mode.
This breaks all existing sites using this module in manual mode (which was the only option so far).
I have made a patch making the blocking mode configurable.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | cookiebot-make_blocking_mode_configurable-3090518-14.patch | 452 bytes | arnested |
| #7 | cookiebot-make_blocking_mode_configurable-3090518-7.patch | 2.11 KB | arnested |
Comments
Comment #2
arnested commentedComment #3
a.milkovskyLet's change this option to a checkbox:
Name: cookiebot_block_cookies
Title: Automatically block all cookies
Description: Defines if Cookiebot should automatically block all cookies until a user has consented.
Comment #4
arnested commentedNo problem. Let's do that. New patch attached.
Comment #5
anybodyPatch looks good, I think we can set this RTBC. Perhapts it would be nice to also add a link to the description of both functionalities in the cookiebot documentation!
Comment #6
anybodyLink: https://www.cookiebot.com/en/automatic-cookie-control/
Comment #7
arnested commentedGood idea, @Anybody. Link added.
Comment #8
anybodyRTBC!
After this has been committed, we should integrate it with #3091260: Blockmode "Auto" will not work in Drupal 8 with core's domready library.
Comment #9
a.milkovskyI guess this is not necessary, right? Looks like we do not need async. I ca not find it in the cookiebot recommendations https://www.cookiebot.com/en/developer/.
Comment #11
a.milkovskyCommitted, thank you for the contribution!
I will make a release for this issue.
P.S. Please let me know if you find the async flag necessary.
Comment #12
a.milkovskyComment #13
a.milkovskyFixed
Comment #14
arnested commentedOne of the points of not using the blocking-mode auto is that you can include the JavaScript in a non-blocking way, a.ka. async.
It's also in the documentation on https://www.cookiebot.com/en/manual-implementation/ (Step 3.1, see the example).
Comment #15
arnested commentedComment #16
anybody@arnested please open a separate issue with the problem you experience in #14. The aim of this issue is solved.
Comment #17
a.milkovskyLet's create a setting for this attribute as well.
agree
Comment #18
arnested commentedI created a new issue: #3097610.