Replace deprecated create_function().

CommentFileSizeAuthor
#4 remove_deprecated_function-3084889.patch4.02 KBRangaswini
#2 evaluate-3084889.patch2.5 KBRangaswini

Comments

Rangaswini created an issue. See original summary.

Rangaswini’s picture

Rangaswini commented
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new evaluate-3084889.patch2.5 KB
Rangaswini’s picture

Rangaswini commented
Status: Needs review » Needs work
Rangaswini’s picture

Rangaswini commented
Title: Replace deprecated function. » Replace eval function.
Status: Needs work » Needs review
StatusFileSize
new remove_deprecated_function-3084889.patch4.02 KB

I have removed deprecated function eval(). Added external library eval-math-master to evaluate the mathematical expression.

Rangaswini’s picture

Rangaswini commented
Assigned: Rangaswini » Unassigned
truptidiwani’s picture

truptidiwani commented
Assigned: Unassigned » truptidiwani
truptidiwani’s picture

truptidiwani commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the patch-
https://www.drupal.org/files/issues/2019-10-04/remove_deprecated_functio... and thus its working well.

Checked:
- The patch is being applied successfully and have tested the following test cases.- For addition, subtraction,divide,multiply,backsapce,clear.
- The libarary eval-math is applied and is working well.

truptidiwani’s picture

truptidiwani commented
Assigned: truptidiwani » Unassigned

jaykandari’s picture

jaykandari
Primary language Hindi
commented
Status: Reviewed & tested by the community » Fixed

Thank you @Rangaswini & @truptidiwani for your contributions.
Patch looks okay to me.
There are few coding standards issue in this, but this can be covered in #3086737 ticket.

jaykandari’s picture

jaykandari
Primary language Hindi
commented
jaykandari’s picture

jaykandari
Primary language Hindi
commented
Related issues: +#3086737: Clean coding style for formula_field.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.