Problem/Motivation

When I want to use some custom provider of push notifications together with (or separate) PWA provider from this module then I can not create some settings wrapper on the user settings page.

Proposed resolution

Update settings section for the user edit page based on a new plugin which will be created here.

Comments

chmez created an issue. See original summary.

ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
Status: Active » Needs work

PR work in progress here: https://github.com/goalgorilla/social_pwa/pull/9

ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
Assigned: ohorbatiuk » Unassigned
Status: Needs work » Needs review
ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Status: Needs review » Reviewed & tested by the community

The idea behind this refactoring and code looks good to me.
Just we need to be sure that it is merged and released together with https://github.com/goalgorilla/open_social/pull/1509

ronaldtebrake’s picture

ronaldtebrake commented
Status: Reviewed & tested by the community » Fixed

  • chmez committed 087b864 on 8.x-1.x 
    Issue #3083980 by chmez: Fix coding standards.
  • chmez committed 0ea0731 on 8.x-1.x
    Issue #3083980 by chmez: Add Open Social to the Composer dependencies.
  • ronaldtebrake authored 98bf5d9 on 8.x-1.x
    Merge pull request #9 from goalgorilla/feature/3083980-user-settings-...
  • chmez committed baa45d0 on 8.x-1.x
    Issue #3083980 by chmez: Move injected services for translating strings...
  • chmez committed ca3b211 on 8.x-1.x
    Issue #3083980 by chmez: Update settings section for the user edit page...
  • chmez committed db772a1 on 8.x-1.x
    Issue #3083980 by chmez: Move functionality for checking access to a...

  • f64d678 committed on 8.x-1.x 
    Revert "Issue #3083980 by chmez: Push notifications provider" (#11)
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Fixed » Needs work

  • dc2112c committed on 8.x-1.x 
    Issue #3083980 by chmez: Push notifications provider (#12)

This...
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.