The cache service is not named properly in services.yml file here is an example of declaration in jsonapi module in core.

  cache.jsonapi_normalizations:
    class: Drupal\Core\Cache\CacheBackendInterface
    tags:
      - { name: cache.bin }
    factory: cache_factory:get
    arguments: [jsonapi_normalizations]
CommentFileSizeAuthor
#13 3083203-13.patch1.42 KBjibran
#13 interdiff-e615a7.txt519 bytesjibran
#10 3083203-2.patch940 bytesjibran
#6 3083203-6.patch2.03 KBjibran
#6 interdiff-dd30cc.txt621 bytesjibran
#4 3083203-4.patch1.68 KBjibran
#4 interdiff-ab6c07.txt785 bytesjibran
#2 3083203-2.patch940 bytesjibran

Comments

jibran created an issue. See original summary.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review
StatusFileSize
new 3083203-2.patch940 bytes

Here is the patch.

Status: Needs review » Needs work

The last submitted patch, 2: 3083203-2.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-ab6c07.txt785 bytes
new 3083203-4.patch1.68 KB

Let's fix the fail.

Status: Needs review » Needs work

The last submitted patch, 4: 3083203-4.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-dd30cc.txt621 bytes
new 3083203-6.patch2.03 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3083203-6.patch, failed testing. View results

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review

Filed #3083313: Fix the failing HEAD so restoring the patch from #2.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Needs work

Needs a reroll

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new 3083203-2.patch940 bytes

I retested the patch in #2. Let me upload it again,

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

Thanks @jibran. I have one thing where I am not 100% sure. I think because we are changing the service definitions, we have to add an empty post_update function to trigger a cache rebuild.
What do you think?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-e615a7.txt519 bytes
new 3083203-13.patch1.42 KB

What do you think?

Yes, that is correct we do need an update hook so here we go.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Thank you

  • chr.fritsch committed ef63f95 on 8.x-2.x authored by jibran 
    Issue #3083203 by jibran: Fix the cache bin declaration in services.yml...
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Done

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.