Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement ConfigurableInterface and/or DependentPluginInterface directly as needed. If you implement ConfigurableInterface you may choose to implement ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility, however this must be removed prior to Drupal 9.

@see https://www.drupal.org/node/2946161

CommentFileSizeAuthor
#2 key-configurable_plugin_interface_deprecation-3076926-2.patch901 bytesaaronbauman

Comments

AaronBauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new key-configurable_plugin_interface_deprecation-3076926-2.patch901 bytes

swap out ConfigurablePluginInterface for ConfigurableInterface and DependentPluginInterface

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch.

  • rlhawk committed 8f9c2c7 on 8.x-1.x authored by AaronBauman 
    Issue #3076926 by AaronBauman: Replace dependency on deprecated...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Fixed
dagomar’s picture

dagomar commented
Status: Fixed » Needs work

I'm sorry to re-open this but since it's been committed so recently I figured it might be useful to add this here.

This patch makes use of ConfigurableInterface, which only became available from drupal 8.7. This means any site still on 8.6 (supported through to december 2019) will have fatal errors. In our case it's possible to upgrade to 8.7, but not everybody will be in that position. See this issue: https://www.drupal.org/project/password_policy/issues/3061382 for the same problem in another module, with some helpful discussion for a solution.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented

Ah, of course. Thanks for bringing this up. I will revert the change and keep this issue open, so it can be addressed closer to the release of Drupal 9.

  • rlhawk committed 3ca8b32 on 8.x-1.x 
    Revert "Issue #3076926 by AaronBauman: Replace dependency on deprecated...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs work » Active
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Reviewed & tested by the community

RTBC is a better issue status. Even if it must be postponed until December 4, 2019.

sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented

8.x-1.10 reverts this change to maintain compatibility with Drupal <8.7, but 8.x-1.11 re-adds ConfigurableInterface hence Drupal 8.6 crashes because of the fatal error: https://git.drupalcode.org/project/key/compare/8.x-1.10...8.x-1.11#4251885a330bd1d6d93385f8e2c8eb672490e8aa

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented

Thanks for catching that. I've reverted the changes to that one file, so the module remains compatible with Drupal 8.6.

  • rlhawk committed 940eb19 on 8.x-1.x authored by AaronBauman 
    Issue #3076926 by AaronBauman: Replace dependency on deprecated...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.