Updated to the latest varbase 8.7.0 release. When loading the dashboard:
The website encountered an unexpected error. Please try again later.
Recoverable fatal error: Object of class Drupal\Core\Link could not be converted to string in Drupal\Core\Render\Markup::create() (line 36 of core/lib/Drupal/Component/Render/MarkupTrait.php).
Drupal\Core\Render\Markup::create(Object) (Line: 181)
Drupal\varbase_total_control\Plugin\Block\VarbaseContentOverview->build() (Line: 135)
Drupal\panels\Plugin\DisplayBuilder\StandardDisplayBuilder->buildRegions(Array, Array) (Line: 176)...Traced it down to: 180 - 184
[
'data' => Markup::create($link),
'class' => ['type'],
],
Should be:
[
'data' => $link->toString(),
'class' => ['type'],
],
Patch to follow later today.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | varbase_total_control-link-could-not-be-converted-to-string-3076843-2.patch | 952 bytes | devkinetic |
Comments
Comment #2
devkinetic commentedComment #3
devkinetic commentedComment #4
rajab natshahComment #6
rajab natshahCommitted ... Thank you :) Ryan for reporting and the patch!!
This will go as a quick fix release.
I think we do need to have an automated test for ( When the comment module is enabled or not )
We did a bit of refactoring work at the Total Control module
#3067821: Fix [Total Control Dashboard] uses of deprecated Drupal core APIs and standard Drupal Practice
We had fixed number of issues like this when we started
#3069156: Add Automated Testing for the Total Control Admin Dashboard module
So we did
#3067824: Fix [Varbase Total Control Dashboard] uses of deprecated Drupal core APIs and standard Drupal Practice
After your report. An automated test check is a must.
Planed to #3076980: Add Automated Testing for the Varbase Total Control Dashboard module
Comment #7
rajab natshahComment #8
rajab natshahComment #9
devkinetic commentedAwesome, glad this has triggered a bigger initiative! Thanks for rolling in so quickly.