I got a thunder installation where I added two entity browsers in one paragraph. With this config I get the same problem as #2979427: subform element <summary> hidden by default. where the field for the second entity browser is hidden completely without a way to interact.

It seems to come from this line https://git.drupalcode.org/project/thunder_admin/blob/8.x-2.7/css/paragr... that was added as a fix in previously mentioned issue. If I remove display:none the field is usable.

Thunder Admin 8.x-2.7 and Thunder 2.42.

CommentFileSizeAuthor
#6 details-3070626-and-3076779.patch1.73 KBvolkerk
#5 show_multiple_entity_browser_in_paragraph-3076779-5.patch628 bytesrogerpfaff
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rogerpfaff created an issue. See original summary.

rogerpfaff’s picture

rogerpfaff
he/his
Primary language German
Location Munich
CreditAttribution: rogerpfaff at Reinblau commented
Issue summary: View changes
rogerpfaff’s picture

rogerpfaff
he/his
Primary language German
Location Munich
CreditAttribution: rogerpfaff at Reinblau commented
Title: Subform summary field hidden » Subform summary element hidden
rogerpfaff’s picture

rogerpfaff
he/his
Primary language German
Location Munich
CreditAttribution: rogerpfaff at Reinblau commented
Title: Subform summary element hidden » Subform second / multiple summary elements hidden
rogerpfaff’s picture

rogerpfaff
he/his
Primary language German
Location Munich
CreditAttribution: rogerpfaff at Reinblau commented
Status: Active » Needs review
FileSize
show_multiple_entity_browser_in_paragraph-3076779-5.patch628 bytes

Here is a patch that removes the display:none for the summaries on video and image browsers completely and seems to work without regression.

Edit: This is only tested in Firefox. I was told that MS Edge might do something else here but I didn't test it.

volkerk’s picture

volkerk CreditAttribution: volkerk at Thunder commented
FileSize
details-3070626-and-3076779.patch1.73 KB

Now only hiding the summary when details element is open. Would this work for you?

https://github.com/BurdaMagazinOrg/theme-thunder-admin/pull/266

  • volkerk authored 28ecbf4 on 8.x-3.x 
    Issues #3070626 and #3076779: fixing details again

  • volkerk authored 36711df on 8.x-2.x 
    Issues #3070626 and #3076779: fixing details again

volkerk credited chr.fritsch.

volkerk’s picture

volkerk CreditAttribution: volkerk at Thunder commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.