Please remove unused variable in entity_embed.module:

FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/entity_embed.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 155 | WARNING | Unused variable $allowed_html.
--------------------------------------------------------------------------
CommentFileSizeAuthor
#8 3072669-fix-unused-variable.patch632 bytesdave reid
#7 3072669-fix-unused-variable.patch627 bytesdave reid
#2 3072669-2.patch643 bytesvuil

Comments

ilchovuchkov created an issue. See original summary.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
StatusFileSize
new 3072669-2.patch643 bytes
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Active » Needs review
dharti patel’s picture

dharti patel commented
Assigned: Unassigned » dharti patel
dharti patel’s picture

dharti patel commented
Assigned: dharti patel » Unassigned
Status: Needs review » Reviewed & tested by the community

Tested the #2 patch and after applying patch remove unused variable errors are eliminate from entity_embed.module file. Need to move to RTBC.

Thanks!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Checking the value against not null seems odd. We may just need to revisit this. Should it be removed? Should it just be a not-empty check (not necessarily a null check)?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3072669-fix-unused-variable.patch627 bytes

Updated version with simplified if statement.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 3072669-fix-unused-variable.patch632 bytes

  • Dave Reid committed 587a004 on 8.x-1.x 
    Issue #3072669 by Dave Reid, vuil: Removed unused variable in...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #8 to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.