The module uses deprecated t() calls. See report in attachments

CommentFileSizeAuthor
#3 3072439-3.patch4.81 KBandypost
#3 interdiff.txt1.57 KBandypost
#2 3072439-use-string-translation-trait-in-render-example.patch5.2 KBlyalyuk
Selection_238.jpg659.21 KBlyalyuk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lyalyuk created an issue. See original summary.

lyalyuk’s picture

lyalyuk CreditAttribution: lyalyuk at Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Active » Needs review
Issue tags: +KharkivCS
FileSize
3072439-use-string-translation-trait-in-render-example.patch5.2 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
interdiff.txt1.57 KB
3072439-3.patch4.81 KB

Testing code should not use t() and so just polished

+++ b/render_example/tests/src/Functional/RenderExampleTest.php
@@ -15,6 +16,8 @@ use Drupal\Tests\BrowserTestBase;
 class RenderExampleTest extends BrowserTestBase {
 
+  use StringTranslationTrait;

@@ -62,7 +65,7 @@ class RenderExampleTest extends BrowserTestBase {
-      t('Save configuration')
+      $this->t('Save configuration')

Test classes should not use translation, core tests mostly cleaned this usage

  • valthebald committed 71da2d0 on 8.x-1.x 
    Issue #3072439 by lyalyuk, andypost: Use string translation trait in...
valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x-1.x, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.