I suggest to support simple patterns in cookie names, at least it would be great to use * to match any characters.
This can be useful for cookies with names which start from the fixed prefix and have arbitrary suffix.

CommentFileSizeAuthor
#19 eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-19-8.x.patch3.42 KBthatguy
#15 eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-15-7.x.patch3.06 KBsvenryen
#15 eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-15-8.x.patch3.45 KBsvenryen
#13 eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-13.patch3.09 KBsvenryen
#2 eu-cookie-compliance-name_pattern-3071922-2.patch3.11 KBmaximpodorov

Comments

maximpodorov created an issue. See original summary.

maximpodorov’s picture

maximpodorov commented
Status: Active » Needs review
StatusFileSize
new eu-cookie-compliance-name_pattern-3071922-2.patch3.11 KB

Status: Needs review » Needs work

The last submitted patch, 2: eu-cookie-compliance-name_pattern-3071922-2.patch, failed testing. View results

svenryen’s picture

svenryen commented
Status: Needs work » Needs review

Thanks for the patch. Looks good.

sinn’s picture

sinn commented

Another solution - https://www.drupal.org/project/eu_cookie_compliance/issues/3039589

ocastle’s picture

ocastle commented

Patch #2 works great.
I personally prefer this option over 3039589. Falls in line with other Drupal wildcards, less error prone and is more user friendly. Little less flexible maybe but has covered all requirements for me.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Closed (duplicate)

I agree with #6! #3039589: Wildcard support in cookie names is much cleaner and better for performance, because it checks for * with a much faster function. Let's close this as duplicate!

maximpodorov’s picture

maximpodorov commented

@Anybody, which solution is better?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Sorry, I pasted the wrong issue id. Of course I ment: #3039589: Wildcard support in cookie names - let's test and review there to get the solution committed please.

maximpodorov’s picture

maximpodorov commented

@Anybody, probably you closed the issue which has better solution. :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Closed (duplicate) » Reviewed & tested by the community

Da** h*** ... I did... SORRY! I should stop reviewing issues at this point, my head seems to overheat ;) SORRY again, I'll close the other one. -.-

This one is RTBC'd instead.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: +Needs backport to D7

Should be backported to D7 as of https://www.drupal.org/project/eu_cookie_compliance/issues/3039589#comme...

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-13.patch3.09 KB

The patch didn't apply cleanly. Here's an updated patch, as well as a port to D7. It would be great if somebody could review.

svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Needs review
svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-15-8.x.patch3.45 KB
new eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-15-7.x.patch3.06 KB

Drupal 7 port and updated Drupal 8 patch that doesn't keeps the term "allow list".

svenryen’s picture

svenryen commented
Priority: Normal » Major
svenryen’s picture

svenryen commented
Issue tags: -Needs backport to D7
svenryen’s picture

svenryen commented
Category: Task » Feature request
thatguy’s picture

thatguy commented
StatusFileSize
new eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-19-8.x.patch3.42 KB

Re-rolled D8 patch from comment #15 to work with latest dev.

Status: Needs review » Needs work

The last submitted patch, 19: eu_cookie_compliance-support-patterns-in-cookie-name-lists-3071922-19-8.x.patch, failed testing. View results

svenryen’s picture

svenryen commented
Title: Support patterns in cookie name lists » [1.x] Support patterns in cookie name lists
svenryen’s picture

svenryen commented
Title: [1.x] Support patterns in cookie name lists » [1.x][2.0.x] Support patterns in cookie name lists
svenryen’s picture

svenryen commented
Status: Needs work » Needs review

  • svenryen committed 5cde010 on 7.x-1.x authored by thatguy 
    Issue #3071922 by svenryen, maximpodorov, thatguy, Anybody, ocastle: [1....
svenryen’s picture

svenryen commented
Status: Needs review » Fixed

Thanks for the patch - tested and committed.

  • svenryen committed 99aa029 on 8.x-1.x authored by thatguy 
    Issue #3071922 by svenryen, maximpodorov, thatguy, Anybody, ocastle: [1....

  • svenryen committed 5cde010 on 7.x-2.x authored by thatguy 
    Issue #3071922 by svenryen, maximpodorov, thatguy, Anybody, ocastle: [1....
  • svenryen committed d6464b0 on 7.x-2.x
    Merge branch '7.x-1.x' into 7.x-2.x

* 7.x-1.x:
  Issue #3178091 by...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.