As described by title. Test with attached module.

drush en raven_drush_test
drush ravenTest:useLoggerMechanism
drush ravenTest:useThrowMechanism

While the logger works as expected, uncaught exceptions slip through.
Is there is some boot-up code necessary?

CommentFileSizeAuthor
#7 raven-3070478-7.patch4.37 KBmfb
#4 raven-3070478-3.patch3.43 KBmfb
#2 raven-3070478.patch1.4 KBmfb
raven_drush_test.zip1.65 KBbits-of-static

Comments

bits-of-static created an issue. See original summary.

mfb’s picture

mfb
they or he
commented
Status: Active » Needs review
StatusFileSize
new raven-3070478.patch1.4 KB

Please try this patch out - we can listen for the console.error event and send the exception to Sentry.

Status: Needs review » Needs work

The last submitted patch, 2: raven-3070478.patch, failed testing. View results

mfb’s picture

mfb
they or he
commented
Status: Needs work » Needs review
StatusFileSize
new raven-3070478-3.patch3.43 KB

This patch adds a new configuration so Drush error capturing has to be enabled on existing installs.

Status: Needs review » Needs work

The last submitted patch, 4: raven-3070478-3.patch, failed testing. View results

mfb’s picture

mfb
they or he
commented
Status: Needs work » Needs review

Presumably these are unrelated test failures since they also affect the dev branch.

mfb’s picture

mfb
they or he
commented
StatusFileSize
new raven-3070478-7.patch4.37 KB

Add mention of the new feature to README.

  • mfb committed 27126bd on 8.x-2.x 
    Issue #3070478 by mfb, bits-of-static: drush commands (php cli?) not...
mfb’s picture

mfb
they or he
commented
Status: Needs review » Fixed

This is hopefully resolved by the new config option for capturing Drush error events.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.