Closed (fixed)
Project:
Configuration selector
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Jul 2019 at 13:29 UTC
Updated:
6 Dec 2019 at 12:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
chr.fritschHere is a patch
Comment #4
chr.fritschFix tests
Comment #5
alexpottLet's makes the tests clean too.
Fixing the above deprecations.
Comment #6
chr.fritschHm, I didn't see the warning about the theme. Neither in tests or with drupal-check. 🤔
I left
drupal_installation_attemptedout, because we would break 8.7 then. But it's only for the tests, so I think it's ok.Comment #7
alexpottHmmm... good point about drupal_installation_attempted() - it's not only tests.
Comment #8
alexpottMaybe what we can do is make this version ^8.8 and Drupal 9 compatible.
Comment #9
alexpottDoes this work...
Comment #10
krzysztof domański-- edited --
Comment #11
krzysztof domański| -> || ??
Now I think it doesn't matter...
Comment #12
krzysztof domańskiComment #13
krzysztof domańskiComment #14
chr.fritschThis looks good. All tests are passing locally with D9.
I think we can release this as a 2.x version.
Comment #15
krzysztof domański1. Why not 8.x-1.0-beta2? Can we just drop 8.6 support and create a next release?
core_version_requirement: ^8.7.7 || ^92. Looking at the patch, we don't remove/change too much code. I think it shouldn't be a problem for Drupal 8.6 support.
Url::fromRoute,MessengerInterfaceare available in older drupal versions so we can also be compatible in 8.6:Comment #16
krzysztof domańskiNew method in 8.8: InstallerKernel::installationAttempted
Proposed solution:
Comment #17
alexpott@Krzysztof Domański we want to maintain the ability to do security releases on 8.x-1.x and be able to test against Drupal 9. Therefore we need two branches.
Thank you for making the tests pass on D9.
I really don't want to maintain code like #16.
Comment #19
alexpott