Problem/Motivation

Claro recently got a bug report related to Features user interface #3067755: Boolean checkbox alignment on Features UI’s feature edit form. While trying to debug the issue we discovered that Features UI works only with Seven or the Seven-based Adminimal theme.

This issue is about the Drupal\features_ui\Form\FeaturesEditForm.

Proposed resolution

Refactor the features edit form and the related admin.css and Javascript to be theme-agnosting:

  • Replace the (theme-provided) CSS classes that are used for JavaScript functionality with classes that are added by the form (or Drupal core).
  • Replace the (theme-provided) CSS classes that are used for component theming classes that are added by the form (or Drupal core).
  • Refactor the admin JS and CSS.

Remaining tasks

Must have: provide a patch.
Good-to-have: since the motivation is to make Features UI theme-agnostic, it would be a great idea to add a JavaScript test(s) for covering the UI’s functionality.

User interface changes

Nothing for Seven or Adminimal
I've just noticed that Features misses some RTL styles, so:

  • No change expected for Seven or Adminimal themes with an LTR language
  • Better RTL styles for Seven or Adminimal
  • Acceptable look for other themes
  • Fully functional JS

API changes

Nothing.

Data model changes

Nothing.

Release notes snippet

Not needed IMHO.

Comments

huzooka created an issue. See original summary.

huzooka’s picture

Assigned: Unassigned » huzooka
huzooka’s picture

Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new21.69 KB
philosurfer’s picture

The issue in #3067755: Boolean checkbox alignment on Features UI’s feature edit form is fixed for me with this patch. (using claro theme)

nedjo’s picture

Thanks for the bug report and for the patch.

This looks good. The test failure looks unrelated.

teroelonen’s picture

Rerolled the patch to 3.x version of Features.

Status: Needs review » Needs work

The last submitted patch, 6: features-ui_theme_agnostic_rtl-3068461-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • nedjo committed 5a0c342 on 8.x-4.x authored by huzooka
    Issue #3068461 by huzooka, teroelonen: Make Features UI theme-agnostic
    

  • nedjo committed 6a60f89 on 8.x-3.x authored by huzooka
    Issue #3068461 by huzooka, teroelonen: Make Features UI theme-agnostic
    
nedjo’s picture

Status: Needs work » Fixed

Applied, thx!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.