Add call parent submitForm in SettingsForm.

CommentFileSizeAuthor
#2 parent_submitForm-3068334-2.patch457 bytessergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
StatusFileSize
new parent_submitForm-3068334-2.patch457 bytes

Here is the patch, please review.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
BarisW’s picture

BarisW commented
Status: Needs review » Closed (works as designed)

I have no idea why this should be done. Please take a bit more time to elaborate on why an change is needed.

sergiu stici’s picture

sergiu stici commented
Status: Closed (works as designed) » Needs review

It's executing a method with the same name on its parent class. This is standard fare in any language when you're dealing with inheritance, when functionality from the base class is still (or may be in the future) required.

Have a read up on Dependency Injection for a Form if this concept is unfamiliar to you.

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Alright, thanks for the info!

  • BarisW committed 3fbfefa on 8.x-1.x authored by Sergiu Stici 
    Issue #3068334 by Sergiu Stici, BarisW: Add call parent submitForm
BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.