Closed (fixed)
Project:
EU Cookie Compliance (GDPR Compliance)
Version:
7.x-1.29
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Jul 2019 at 21:58 UTC
Updated:
4 May 2020 at 13:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
valssi commentedThe field [popup_agree_button_message] is on the admin form but hidden for some reason. I was still able to change/translate the text.
Comment #3
svenryen commented@jukka792 and @valssi , can you run `
drush vget eu_cookie_compliance` and share the output?Comment #4
vradova commentedHello!
I have the same issue and fix it by change code in file "eu_cookie_compliance.admin.inc".
I have replace line from 347 to 360 with this code:
"$form['popup_message']['eu_cookie_compliance']['popup_agree_button_message'] = array(
'#type' => 'textfield',
'#title' => t('Agree button label'),
'#default_value' => isset($popup_settings['popup_agree_button_message']) ? $popup_settings['popup_agree_button_message'] : t('OK, I agree'),
'#size' => 30,
'#states' => array(
'visible' => array(
'input[name="eu_cookie_compliance[enable_save_preferences_button]"]' => array('!value' => 'default'),
),
'required' => array(
'input[name="eu_cookie_compliance[method]"]' => array('!value' => 'default'),
),
),
);"
I know that I should made a patch but right now I do not have a time for this. Sorry :(
Just change those lines and flush Drupal cache. After that you will get a field with option to change label OK, I agree.
Regards, Vlade.
Comment #5
jukka792 commentedThanks, #4 worked for me
Comment #6
florianmuellerchPatch from comment #4. Wrong state visible condition fixed.
Comment #7
florianmuellerchComment #8
svenryen commentedThank you for the patch @fmueller_previon.
There is one problem with this patch;
when the user has selected "Opt-in with categories." and "Replace the Agree button …", the "Agree button label" field is supposed to be hidden.
With your patch, the "Agree button label" field stays visible.
The issue needs work.
Comment #9
svenryen commentedHere are patches that work.
With this code, the Agree button label field is visible when the consent method is set to Categories AND the checkbox to replace the Agree button with Accept all categories is NOT checked, OR when ANY other consent method category is selected.
Comment #12
svenryen commentedComment #14
joachim desarmenien commentedHello,
Thanks you very much for your work.
We have about 40 Drupal websites running with this module, patching each one would be very time consuming.
Is there a plan to commit this patch to the module ?
Thank you very much
Comment #15
smurfxx commentedI'm in the same situation of @joachim desarmenien, the patch works and it's mandatory for this module, I don't know why it's not committed yet!
Comment #16
lowfidelityIf you're just looking for a quick fix without patching your site, you can simply visit the admin page, start your browser's inspector (like firebug or chrome developer tools) usually by clicking F12, then search for "form-item-eu-cookie-compliance-popup-agree-button-message" and display the missing textfield by removing the "display:none" property of that dom element.
Comment #17
wotney commentedWhy on earth is the "form-item-eu-cookie-compliance-popup-agree-button-message" set to display:none ????
Comment #18
PatricNox commentedWithout patch:
Go to the settings page in admin
/admin/config/system/eu-cookie-compliance
Right click -> inspect -> console
Paste this:
document.querySelector('.js-form-item-popup-agree-button-message').style.display = 'block';
Comment #19
drupaldope commentedthis is not fixed in Drupal 8
Comment #20
charlysole commented@wotney
absolutelly right
Why on earth is the "form-item-eu-cookie-compliance-popup-agree-button-message" set to display:none ????
just change display none to block or disable that css rule and it works perfectly!
Comment #21
2flower commented7.x-1.31, still invisible. Why?