Chosen's library supports an option `max_shown_results` which limits the number of results shown. This is quite critical (IMO) for performance when there are a lot of options.

CommentFileSizeAuthor
#10 3065967-10.patch3.56 KBidebr
#10 interdiff-6-10.txt4.25 KBidebr
#6 3065967-6.patch6.05 KBidebr
#6 3065967-6-test-only.patch3.37 KBidebr
#6 interdiff-4-6.txt496 bytesidebr
#4 3065967-4.patch6.05 KBidebr
#4 3065967-4-test-only.patch3.37 KBidebr
#4 interdiff-2-4.txt4.82 KBidebr
#2 3065967-2.patch2.01 KBjerrylow

Comments

jerrylow created an issue. See original summary.

jerrylow’s picture

jerrylow commented
StatusFileSize
new 3065967-2.patch2.01 KB

Adding patch for this.

nagy.balint’s picture

nagy.balint commented
Status: Active » Needs work

Hi!

Thanks for the patch!

The schema and default value definitions are missing however from the patch. Look at the "config" folder of the module.

idebr’s picture

idebr commented
Assigned: jerrylow » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-4.txt4.82 KB
new 3065967-4-test-only.patch3.37 KB
new 3065967-4.patch6.05 KB

Attached patch implements the following changes:

  1. Added max_shown_results to the chosen.settings configuration schema
  2. Updated the Chosen configuration form with the description from the Chosen options page https://harvesthq.github.io/chosen/options.html
  3. Added a FunctionalJavascript test
idebr’s picture

idebr commented
Title: No settings for `max_shown_results` » Allow `max_shown_results` to be configured through the Chosen configuration form
idebr’s picture

idebr commented
StatusFileSize
new interdiff-4-6.txt496 bytes
new 3065967-6-test-only.patch3.37 KB
new 3065967-6.patch6.05 KB

Fixed the FunctionalJavascript test namespace.

Status: Needs review » Needs work

The last submitted patch, 6: 3065967-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nagy.balint’s picture

nagy.balint commented

Seems the patch fails on the line

$this->cssSelect('.chosen-search-input')[0]->focus();

idebr’s picture

idebr commented

Yes, I forgot the Drupal testbot does not actually have to Chosen library so it's pretty moot to put in any kind of testing related the Chosen itself.

idebr’s picture

idebr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-6-10.txt4.25 KB
new 3065967-10.patch3.56 KB

Attached patch implements the following changes:

  1. Removed changes to the current tests.
  2. Added a default value for max_shown_results in the install config.

  • nagy.balint committed 34dcde3 on 8.x-2.x authored by idebr 
    Issue #3065967 by idebr, jerrylow: Allow `max_shown_results` to be...
nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.