The module does not work with sites which use multilingual domains.
The generated url needs to enforce relative urls rather than assume it's always relative..

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

StatusFileSize
new1.22 KB
floydm’s picture

StatusFileSize
new1.05 KB

Thanks for this patch! It works as expected. The only issue I had was that composer couldn't apply it against 8.x-3.7. I'm not sure if that is because of changes between 8.x-3.6 and 8.x-3.7 or because the patch header is a bit unusual. Regardless, attached is a reroll of this change that composer applies successfully.

floydm’s picture

Status: Active » Needs review
pierrelbz’s picture

Version: 8.x-3.6 » 4.0.3
StatusFileSize
new1.04 KB

Thanks for te patch
works as expected
Reroll for v4.0.3

trackleft2 made their first commit to this issue’s fork.

trackleft2’s picture

Added a merge request that rerolls this for 4.x (4.19).

tessa bakker’s picture

Version: 4.0.3 » 4.x-dev
Status: Needs review » Needs work

MR 56 needs work, the new url contains a double forward slash '/', one for the domain, one for the beginning of the path.

yevko’s picture

For me MR 56 works well, with the domain-based language negotiation. No extra slashes. But the language support does not work in this case anyway, e.g. having local at https://domain-en.local and corresponding prod's domain at https://www.domain.com there is no way to redirect from https://domain-fi.local to https://www.domain.fi

I also think that https://www.drupal.org/project/environment_indicator/issues/3092900 is a duplicate of this issue, since the problem reported there is fixed by this patch.

trackleft2’s picture

@yevko, please mark as reviewed and tested if you are sure about your testing.

@tess bakker we might need an issue about trimming the input to remove any slashes, and possibly a post_update.php implementation to update config for any sites who might have a trailing slash.

trackleft2’s picture

trackleft2’s picture

@tess bakker I've updated #3425491: Hostname field isn't a hostname but a base URL to include form validation that determines whether the user has added a trailing slash.
Additionally, I've added a database update in the merge request, that fixes any urls in configuration that happen to have a trailing slash. Please review, and mark this as RTBC and possibly that issue too if you can.

trackleft2 changed the visibility of the branch 4.x to hidden.

trackleft2’s picture

Status: Needs work » Needs review

trackleft2 changed the visibility of the branch 3065135-add-support-for-tugboat to hidden.

trackleft2 credited jaypan.

trackleft2’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.