While working on the port of the Entity Embed CKEditor Plugin's test coverage to core in #2940029: Add an input filter to display embedded Media entities, I spotted:
- The copying of an existing file instead of using
TestFileCreationTrait - Several unused test class properties
- Inaccurate comments
- Every test is calling
drupalLogin($this->adminUser)— might as well do that in::setUp()then :) - Some unnecessarily complex XPath-based element selection, converting them to CSS-based selectors simplifies the tests and makes them accessible to more people
- Some missing "waits"
- A few assertions that are too high-level and thus don't necessarily prove something is still working
- Some typos
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3064782-2.patch | 17.12 KB | wim leers |
Comments
Comment #2
wim leersFixed all of the above.
Comment #3
wim leersGreen!
Comment #4
wim leersComment #5
wim leersComment #7
wim leers🙃