In the parent issue we implemented a way to remove the pointers to the remote workspaces in case those are not accessible anymore, but we didn't take into consideration then that there could be a temporary network problem that can make those non-accessible. In that case deleting the pointer at cron is not correct - that can cause other issues, for example the pointer will be deleted, then added back, but it will be already removed as target for the local workspace. That can can be confusing.

My proposed solution is to not remove the target endpoint, but only disable the radio button with the non-accessible pointer (and maybe make the label red for it). In that case even if the remote workspace is not accessible temporary or it was deleted at all, users won't be able to select it as target. In the case the workspace was already selected and after that it becomes accessible and there is a deployment queued from it or to it, then that shouldn't cause any issues after fixing another issue I'm working on: #3062703: Don't set replication status to failed, if deployment failed before it started Assigned to: jeqq

With the proposed solution the remote pointers will be deleted only in one case - if the remote is deleted from the Remotes list page. Otherwise, even if the remote workspace don't exist anymore, it's pointer will remain on the Workspace edit page as disabled option.

Comments

jeqq created an issue. See original summary.

jeqq’s picture

Issue summary: View changes
jeqq’s picture

Title: Followup: Removing pointers for non-accessible remote workspaces is not correct when there is an temporary network problem » Followup: Removing pointers for non-accessible remote workspaces is not correct when there is a temporary network problem
jeqq’s picture

Assigned: Unassigned » jeqq
jeqq’s picture

Status: Active » Needs review
StatusFileSize
new5.86 KB
jeqq’s picture

This will also need the latest changes from https://github.com/relaxedws/couchdb-replicator, master branch.

jeqq’s picture

How some of the fixes included in this patch, together with #3062703: Don't set replication status to failed, if deployment failed before it started look:

- when all remote workspaces available:

workspaces available

- when not all remote workspaces are available:

not all workspaces available

jeqq’s picture

dixon_’s picture

Status: Needs review » Needs work

@jeqq Let's change the message to a regular warning message. Other than that, I think this looks great.

jeqq’s picture

Status: Needs work » Needs review
StatusFileSize
new6.11 KB
new2.39 KB
new122.63 KB

Changes per #9:

msg

  • jeqq committed cbac70c on 8.x-1.x
    Issue #3062705 by jeqq, dixon_: Followup: Removing pointers for non-...
jeqq’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.