In the parent issue we implemented a way to remove the pointers to the remote workspaces in case those are not accessible anymore, but we didn't take into consideration then that there could be a temporary network problem that can make those non-accessible. In that case deleting the pointer at cron is not correct - that can cause other issues, for example the pointer will be deleted, then added back, but it will be already removed as target for the local workspace. That can can be confusing.
My proposed solution is to not remove the target endpoint, but only disable the radio button with the non-accessible pointer (and maybe make the label red for it). In that case even if the remote workspace is not accessible temporary or it was deleted at all, users won't be able to select it as target. In the case the workspace was already selected and after that it becomes accessible and there is a deployment queued from it or to it, then that shouldn't cause any issues after fixing another issue I'm working on: #3062703: Don't set replication status to failed, if deployment failed before it started Assigned to: jeqq
With the proposed solution the remote pointers will be deleted only in one case - if the remote is deleted from the Remotes list page. Otherwise, even if the remote workspace don't exist anymore, it's pointer will remain on the Workspace edit page as disabled option.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff.txt | 2.39 KB | jeqq |
| #10 | 3062705-10.patch | 6.11 KB | jeqq |
| #5 | 3062705-5.patch | 5.86 KB | jeqq |
Comments
Comment #2
jeqq commentedComment #3
jeqq commentedComment #4
jeqq commentedComment #5
jeqq commentedComment #6
jeqq commentedThis will also need the latest changes from https://github.com/relaxedws/couchdb-replicator, master branch.
Comment #7
jeqq commentedHow some of the fixes included in this patch, together with #3062703: Don't set replication status to failed, if deployment failed before it started look:
- when all remote workspaces available:
- when not all remote workspaces are available:
Comment #8
jeqq commentedComment #9
dixon_@jeqq Let's change the message to a regular warning message. Other than that, I think this looks great.
Comment #10
jeqq commentedChanges per #9:
Comment #12
jeqq commented