Broken tests since commit 8d4ee39 (19.July.2018)

see my comment here:

#1991988-67: Adding a new translation overwrites the English/source field value

there's a patch that seems to improve the test results from 4 errors down to only 2 errors.

review that please

here is a revert all the way back to Oct 2017 when the tests used to pass.

just for testing purposes, do not actually use this patch.

so lets figure out why?

Hi Stefanos, thanks for the background info, it will help us pinpoint the test changes needed.

Ok, not sure if this patch will help.

just a hunch, but ya maybe instead of LANGUAGE_NONE we have to look for the default language

Other places in the test results to update

grep LANGUAGE * -R
TitleFieldReplacementTestCase.test:      $entity->{$field_name}[LANGUAGE_NONE][0]['value'] = $label;
TitleTranslationTestCase.test:    entity_translation_get_handler('taxonomy_term', $term)->setOriginalLanguage(LANGUAGE_NONE);
TitleTranslationTestCase.test:      $term->{$field_name}[LANGUAGE_NONE] = $term->{$field_name}[$langcode];
TitleTranslationTestCase.test:    $this->assertTrue($this->checkFieldValues($term, $original_values, LANGUAGE_NONE), 'Term original language correctly changed to the former translation language.');
TitleTranslationTestCase.test:      $term->{$field_name}[$translation_langcode] = $term->{$field_name}[LANGUAGE_NONE];
TitleTranslationTestCase.test:      $term->{$field_name}[LANGUAGE_NONE] = array();
TitleTranslationTestCase.test:    $original_values['name'] = LANGUAGE_NONE . '_' . $this->randomName();
TitleTranslationTestCase.test:    $this->assertEqual($term->{$field_name}[LANGUAGE_NONE][0]['value'], $original_values['name'], 'Untranslatable replacing field on translatable entity correctly handled.');

I changed one , but maybe have to change all of these from LANGUAGE_NONE to the default language using the language_default() function to grab it, then grab the code $langdefault->language

short on time here

ah maybe not.

ok revert the patch that breaks tests.

try again

ok another patch comming

this should fix the php 5.3.x and php 5.4.x fails.

ok minor simplification of code here.

stefanos, do you have an opinion on this patch? I'm of the opinion that it's the best thing we have currently. Until something better comes along.

Stefanos, I stand by the nested if, only want to call entity_language() if the entity type is set, otherwise lacking type for entity_language() ?
Not sure how setting $entity_language to NULL will avoid this nesting?

As for the straight up revert see patch 17 in comment 16, php 5.3 and 5.4 fails

hmm, ok, if this patch fails I'll try that.
not even sure if we need the tertiary logic

trying this

diff --git a/tests/title_test.module b/tests/title_test.module
index aa60f55..4e5c211 100644
--- a/tests/title_test.module
+++ b/tests/title_test.module
@@ -87,7 +87,7 @@ function title_test_phase_check($phase, $entity) {
   $label_key = $info['entity keys']['label'];
   $field_name = $label_key . '_field';
   $langcode = LANGUAGE_NONE;
-  if (!empty(entity_language($entity->type, $entity))) {
+  if (isset($entity->type)) {
     $langcode = entity_language($entity->type, $entity);
   }
   $value = $entity->{$label_key} == $entity->{$field_name}[$langcode][0]['value'];

Stefanos, any objections?

@stefanos, do you recommend going ahead with a release with this fix?

Thanks @ram4nd , we might as well push a release with this.