When I dismiss the banner by clicking Save, and I have not chosen any option, there's no need for the browser to ask for permission to send push notifications.

Steps to reproduce
====================
1. Open any page on where the push notification bell is visible
2. Click the push notification bell
3. Make sure no options are selected
4. Click Save

Result
====================
The browser asks for permission to send push notifications

Expected
====================
When no option is selected I expect the browser not to ask for permission.

Comments

svenryen created an issue. See original summary.

efpapado’s picture

Version: 7.x-1.0-alpha2 » 7.x-1.x-dev
Assigned: Unassigned » efpapado
Status: Active » Needs review
StatusFileSize
new1.6 KB

I think that this patch fixes it.

svenryen’s picture

Status: Needs review » Reviewed & tested by the community

I tested this patch on a site and after I select no options I'm no longer asked for permissions. If I select one or more options, I get the permission dialog in the browser. Good to go!

  • efpapado committed 6d643e3 on 7.x-1.x
    Issue #3056042 by efpapado, svenryen: When I choose no subscription and...
efpapado’s picture

Status: Reviewed & tested by the community » Fixed

Committed.
And I think it's time for a new release, we had quite a few fixes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.