1. Add a checkbox to enable/disable to add a tab for the Instance Pricing List view (for internal Instance Pricing)
  2. Add a checkbox to enable/disable to add Google Spreadsheet - Google fieldset for Google Credential should move inside this Cost Management fieldset?
  3. Add a checkbox to enable/disable Instance Type cost in Server Template
  4. Add a checkbox to enable/disable Cost List in the confirmation page of Launching an instance
  5. Add a checkbox to enable/disable to show the cost of each instance in the instance list view
CommentFileSizeAuthor
#21 3053038-21.patch24 KBxiaohua guan
#19 3053038-19.patch24 KBxiaohua guan
#13 3053038-13.patch24.04 KBxiaohua guan
#10 3053038-10.patch23.16 KBxiaohua guan
#7 3053038-7.patch23.23 KBxiaohua guan
#4 3053038-4.patch16.56 KBxiaohua guan
#3 3053038-3.patch16.56 KBxiaohua guan
#2 3053038-2.patch12.8 KBxiaohua guan

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3053038-2.patch12.8 KB
xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3053038-3.patch16.56 KB
xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3053038-4.patch16.56 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

@yas

Please review the patch file. Thanks.

Status: Needs review » Needs work

The last submitted patch, 4: 3053038-4.patch, failed testing. View results

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3053038-7.patch23.23 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: 3053038-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3053038-10.patch23.16 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: 3053038-10.patch, failed testing. View results

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3053038-13.patch24.04 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
xiaohua guan’s picture

xiaohua guan commented

@yas

Please review the patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for providing the patch. It looks good to me for now.

@baldwinlouie
@masami

What do you think?

baldwinlouie’s picture

baldwinlouie commented

@all, This patch looks good.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work
Related issues: +#3052935: Fix all the coder messages

@baldwinlouie

Thank you for your review.

@xiaohua-guan

As we discussed internally, after merging the patch at 3052935, the patch needs to work around. Could you please re-create the patch? I changed this issue status to Needs work.

Thanks
Yas

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3053038-19.patch24 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3053038-21.patch24 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the updated patch. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 8eb7930 on 8.x-1.x authored by Xiaohua Guan 
    Issue #3053038 by Xiaohua Guan, yas, baldwinlouie: Add configurations to...

  • yas committed 417fc54 on 8.x-2.x authored by Xiaohua Guan 
    Issue #3053038 by Xiaohua Guan, yas, baldwinlouie: Add configurations to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@all

FYI, I'll release 8.x-1.1-beta2 based on this commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.