Problem/Motivation

Message Notice: Undefined index: version in git_deploy_system_info_alter() (line 97 of /app/modules/git_deploy/git_deploy.module) #0 /app/core/includes/bootstrap.inc(587): _drupal_error_handler_real(8, 'Undefined index...', '/app/modules/gi...', 97, Array)

CommentFileSizeAuthor
#5 git_deploy.3050235.patch799 byteskfritsche
#2 git_deploy-Undefined_index_version_on_git_deploy.module-3050235-2-D8.patch440 bytesthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new git_deploy-Undefined_index_version_on_git_deploy.module-3050235-2-D8.patch440 bytes
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

#3059316: Tests fail due to undefined index in git_deploy fails due to the same reason. Why would the info version not be set for core? It should either be set from .info data or by git_deploy itself no? This sounds like may be a symptom of a bigger problem?

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
StatusFileSize
new git_deploy.3050235.patch799 bytes

Just did a little bit of debugging and found out that I can reproduce the error if I have a checked out core, thats probably what drupal test bot also does?

After a bit of digging found that the branch regular expression is not working for core:

          // Any Drupal-formatted branch.
          $branch_preg =  '\d+\.x-\d+\.';

core branch names are 8.7.x and not 8.x-2.x

Patch attached to fix this.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: [BUG] Undefined index version on git_deploy.module » Core version is not identified properly when that is also a git checkout

  • Gábor Hojtsy committed b7892a9 on 8.x-2.x 
    Issue #3050235 by kfritsche, Gábor Hojtsy: Core version is not...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Yay, thanks a lot. I made some minor changes to the code comments and committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.