I was just thinking, it might be cool to have an abstracted service for file (like sites/default/files) handling. One use case that would be great is symlinking files on import instead of copying them, which would save a lot of disk space. Another may be to do nothing so that you could use something like S3.

Assigning to me since this is fairly complex.

CommentFileSizeAuthor
#7 interdiff-3049979-6-7.txt4.5 KBsamuel.mortenson
#7 3049979-7.patch23.28 KBsamuel.mortenson
#6 3049979-6.patch19.28 KBsamuel.mortenson
#6 interdiff-3049979-4-6.txt763 bytessamuel.mortenson
#4 3049979-4.patch18.42 KBsamuel.mortenson

Comments

samuel.mortenson created an issue. See original summary.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Assigned: samuel.mortenson » Unassigned

Un-assigning. This is still complex but I feel like someone else could give this a shot and I could pick it up from there.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Title: [Performance] Symlink files instead of copying them » Add an abstract service for handling file exports
Assigned: Unassigned » samuel.mortenson

I'm handling this now - not doing symlinks by default for complexity reasons but we'll ship with an optional no-op service.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3049979-4.patch18.42 KB

Not sure what tests look like for this yet since it's a refactor.

Status: Needs review » Needs work

The last submitted patch, 4: 3049979-4.patch, failed testing. View results

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3049979-4-6.txt763 bytes
new 3049979-6.patch19.28 KB
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
StatusFileSize
new 3049979-7.patch23.28 KB
new interdiff-3049979-6-7.txt4.5 KB

Added tests.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs review » Fixed

  • samuel.mortenson authored b43f4f9 on 8.x-1.x 
    Issue #3049979 by samuel.mortenson: Add an abstract service for handling...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.