We need your module to work with redis, so here is the implementation.

Comments

szantog created an issue. See original summary.

szantog’s picture

Status: Active » Needs review
StatusFileSize
new3.04 KB
nikunjkotecha’s picture

Status: Needs review » Needs work

Hi szantog,

This will be for sure a nice welcome addition :)

Couple of minor things to update:
1. Can you update readme as well for this?
2. $a = ''; in deleteAll(), I assume it is to pass the code sniffer or similar tests, can you add a comment to explain purpose of it? Or remove if not required and it is just missed during cleanup

szantog’s picture

StatusFileSize
new7.33 KB

Tx for your quick response, here is an update.

szantog’s picture

Status: Needs work » Needs review

I had to create test, because the redis instance on my localhost a little bit messy.

nikunjkotecha’s picture

thanks for the tests, I'll find some time this weekend to implement in other two :)

Status: Needs review » Needs work

The last submitted patch, 4: 3047117-4-redis-integration.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

nikunjkotecha’s picture

Status: Needs work » Needs review
StatusFileSize
new7.36 KB
nikunjkotecha’s picture

StatusFileSize
new7.26 KB

Fix coding standards messages

modules/pcb_redis/tests/src/Kernel/PermanentRedisBackendTest.php
line 3 Namespaced classes, interfaces and traits should not begin with a file doc comment
7 Doc comment short description must end with a full stop
7 Doc comment short description must be on a single line, further text should be a separate paragraph
42 Expected 1 blank line before function; 2 found
106 Expected 1 blank line after function; 2 found
125 Line exceeds 80 characters; contains 103 characters

nikunjkotecha’s picture

Status: Needs review » Fixed
nikunjkotecha’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.