We need your module to work with redis, so here is the implementation.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3047117-9.patch | 7.26 KB | nikunjkotecha |
| #4 | 3047117-4-redis-integration.patch | 7.33 KB | szantog |
We need your module to work with redis, so here is the implementation.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3047117-9.patch | 7.26 KB | nikunjkotecha |
| #4 | 3047117-4-redis-integration.patch | 7.33 KB | szantog |
Comments
Comment #2
szantog commentedComment #3
nikunjkotechaHi szantog,
This will be for sure a nice welcome addition :)
Couple of minor things to update:
1. Can you update readme as well for this?
2. $a = ''; in deleteAll(), I assume it is to pass the code sniffer or similar tests, can you add a comment to explain purpose of it? Or remove if not required and it is just missed during cleanup
Comment #4
szantog commentedTx for your quick response, here is an update.
Comment #5
szantog commentedI had to create test, because the redis instance on my localhost a little bit messy.
Comment #6
nikunjkotechathanks for the tests, I'll find some time this weekend to implement in other two :)
Comment #8
nikunjkotechaComment #9
nikunjkotechaFix coding standards messages
modules/pcb_redis/tests/src/Kernel/PermanentRedisBackendTest.php
line 3 Namespaced classes, interfaces and traits should not begin with a file doc comment
7 Doc comment short description must end with a full stop
7 Doc comment short description must be on a single line, further text should be a separate paragraph
42 Expected 1 blank line before function; 2 found
106 Expected 1 blank line after function; 2 found
125 Line exceeds 80 characters; contains 103 characters
Comment #11
nikunjkotechaComment #12
nikunjkotechahttps://www.drupal.org/project/pcb/releases/8.x-1.6