Drupal 9 compatibility

Just one deprecation notice:

Remaining deprecation notices (2)

  2x: assertNoCacheTag() is deprecated and scheduled for removal in Drupal 9.0.0. Use $this->assertSession()->responseHeaderNotContains() instead. See https://www.drupal.org/node/2864029.
    2x in BigPipeSessionlessTest::testBigPipeNoSession from Drupal\Tests\big_pipe_sessionless\Functional

Will fix.

http://hojtsy.hu/blog/2019-oct-16/join-imadedrupal9-drupalcon-amsterdam-...

+++ b/big_pipe_sessionless.info.yml
@@ -3,6 +3,7 @@ type: module
+core_version_requirement: ^8 || ^9

This must be at least 8.7.7. That also means we can drop the core: 8.x line. And it means we can simplify our dependencies.

Everything else looks great, thanks! 👍

Forgot the big_pipe_sessionless_test.info.yml file 😬

Without this patch getting committed, DrupalCI won't be able to install this on D9. I know for a fact that we'll need more changes, for example https://www.drupal.org/node/3083055, but that's impossible to see now. So let's commit #12 and then continue from there in this same issue.

And now for part 2.

Because core BigPipe tests use the classy, we must too.

So as per #18…

PHP 7.3 & 7.4 behave differently:

• 7.3 = hard fail: https://www.drupal.org/pift-ci-job/1711485
• 7.4 = pass: https://www.drupal.org/pift-ci-job/1711465

So, we can have either D9 + PHP 7.4 or D 8.x + PHP 7.3, but we can't have D9 + PHP 7.3 in the same branch. I don't want to create a new branch just for this, so I'm gonna bump the PHP required version to PHP 7.4. Per https://www.php.net/supported-versions.php, PHP 7.3 support ends in 6 months anyway. If you're moving to D9, you are probably moving on to PHP 7.4 anyway.

Thanks @alexpott for the rubberducking/thinking to figure out the puzzling behavior in #18 🙃

@Dom.: 👋🏻 Long time no see!

See #19 for my reasoning. Symfony forced the signature change. I had to choose between multiple branches or bumping the required PHP version. I chose to bump the required PHP version since PHP 7.3 will be EOL in 6 months anyway.

It does not feel like compatible with D8.7.7 as it stands in the core_requirements that way.

This is true; I should've updated that in #19 too 😬

My choice was rooted in pragmatism, but obviously it's causing disruption for you. And truth be told, a PHP version requirement bump is a trigger for a new major version per semver.

So … I'm going to do exactly what you suggested. I'll ask you to verify what's in both the 8.x-1.x branch and the 2.x branch shortly; I'll set this issue to Needs review at that time.

I will unpublish the 8.x-1.3 release and instead release a 2.0 version that is compatible with Drupal 9. I will revert both commits to the 8.x-1.x branch that this issue made.

UGH I picked the wrong patch for the 2.x branch 😬

#28 shows that the approach proposed in #25 + #26 works:

1. 8.x-1.x is D8-only and does not bump the PHP version requirement
2. 2.x is D9-only and also works on PHP 7.3, unlike the 8.x-1.3 release I made last week

AFAICT this addresses all of @Dom.' s concerns. Please confirm! 🙏

Excellent, thanks!

The one thing I disagree with is to tag a 8.x-1.4 release. Like I wrote in #26: I will unpublish the 8.x-1.3 release, so that 8.x-1.2 is again the latest. Because literally nothing changed since 8.x-1.2:

$ git log --oneline -n 5 8.x-1.x
387f6df (origin/8.x-1.x, 8.x-1.x) Issue #3046409 by Wim Leers, Dom.: The 8.x-1.x branch can not be compatible with Drupal 9 if it must also continue to support PHP 7.3 due to a Symfony-forced function signature change
80e8c66 (tag: 8.x-1.3) Issue #3046409 by Wim Leers, alexpott: Drupal 9 compatibility
c2b79e6 Issue #3046409 by Wim Leers, dmytro-aragorn, GaëlG, chegor: Drupal 9 installability
7031e80 (tag: 8.x-1.2) Issue #2962008 by Wim Leers: Coding standards: comply with as much of the 'Drupal' coding standard as possible, add phpcs.xml to opt out of a few rules
5125289 Issue #2942484 by Wim Leers, ABaier, notnotnate, glass.dimly: HEAD requests: "Notice: Undefined offset"
$ git d 8.x-1.2 8.x-1.x

Unpublished https://www.drupal.org/project/big_pipe_sessionless/releases/8.x-1.3. Released https://www.drupal.org/project/big_pipe_sessionless/releases/2.0.0