Make selection of available link targets configurable

Hi Orlando,

This sounds good, I don have time myself to implement this, so feel free to do this :-)

Thanks!

Wow really nice! work like a charm!

Tested by updating the module with this patch. I see that you have an update hook in place that creates the config.
Totally makes sense.

It's a really big patch, but I could not find any issues with it.

I tried selecting only _blank and _self. and it just works!

A much simpler approach would be to make this part of the widget settings, and this would also give a site builder the option of having different targets available per content type or bundle.

The attached patch implements this approach, please test.

Hello @mandclu,

I tested your patch against the dev version, and I get the following error in the form display:

The website encountered an unexpected error. Please try again later.
Error: Using $this when not in object context in Drupal\link_target\Plugin\Field\FieldWidget\LinkTargetFieldWidget::getTargets() (line 77 of modules/contrib/link_target/src/Plugin/Field/FieldWidget/LinkTargetFieldWidget.php).

Drupal\link_target\Plugin\Field\FieldWidget\LinkTargetFieldWidget::getTargets() (Line: 42)
Drupal\link_target\Plugin\Field\FieldWidget\LinkTargetFieldWidget->settingsForm() (Line: 455)
Drupal\field_ui\Form\EntityDisplayFormBase->buildFieldRow() (Line: 40)
Drupal\field_ui\Form\EntityFormDisplayEditForm->buildFieldRow() (Line: 218)
Drupal\field_ui\Form\EntityDisplayFormBase->form() (Line: 149)
Drupal\Core\Entity\EntityForm->buildForm()
call_user_func_array() (Line: 532)
Drupal\Core\Form\FormBuilder->retrieveForm() (Line: 278)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 91)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 57)
Drupal\Core\StackMiddleware\Session->handle() (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 91)
Drupal\shield\ShieldMiddleware->handle() (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 23)
Stack\StackedHttpKernel->handle() (Line: 708)
Drupal\Core\DrupalKernel->handle() (Line: 19)

The problem is that you are using $this inside a static function.

You can either make that function not static or simply use t().

Thank you.

@maursilveira thanks for the feedback. Here's an updated patch that should address the error you found.

Hello @mandclu.

Patch #10 fixes the reported issue, and it works great. I took the liberty to add a couple of changes to it in the patch attached into this comment.

1. Display the message "No target options were selected." in the function settingsSummary() if no available target options are selected. The previous code was displaying "Available targets:".
2. Remove the select element "Select a target" from the add/edit form if no available target options are selected. The previous code generated the target selector, but the only option was "- None -".

Could you please review it? Please let me know what you think about this, or if you have any questions.

Thank you.

Mauricio

Thanks for the additional feedback. I agree that the previous patch didn't properly handle an empty set of targets, but I think the solution should be to default to showing all instead. If they don't want any targets allowed, why use this widget at all?

Here's an updated patch that should fix the behaviour, to show all target options if none were selected.

I wasn't able to generate an interdiff from your patch (the error was "Whitespace damage detected in input") so providing an interdiff from the patch in #10 instead.

Hello @mandclu,

I totally agree with you. I made that change to hide the filter when no available options were selected because I thought that was by design. But I agree that if no options are manually selected that should mean that all options will be available.

I tested the patch in #13 and it works great. Thank you for the patch.

Mauricio

Thanks again for all your feedback and help on this issue. Merged in, and will roll a new release shortly.