Steps to reproduce:

- Install/enable Entity Pager module version 1.0.0-beta2
- Enable Entity Pager example View at Structure > Views
- Go to Structure > Block layout; place Entity pager example block in a region (Content, Sidebar, etc). Apply Content type visibility (aka Only show the block on Content pages). Save blocks layout.
- Visit Content.

- < prev link is plain text, not linked
- next > link points to a node, click it.
- When you get to the next node, it's the same pager. No link in prev, next links to same node. Clicking it will just reload that node again.

I had a working Entity pager that was rather complex and took me days to get working. I updated via COmposer, yesterday, and today realized the pager no longer worked. I spent hours, today, thinking I had done something to it and forgot, but eventually I gave up and re-tested the Example pager and realized that it is no longer working, either.

Has anyone else experienced this with "beta2" which came out, yesterday?

Thanks.

CommentFileSizeAuthor
#4 3043003-issue-with-class.diff389 bytesddiestra

Comments

ccshannon created an issue. See original summary.

sproets’s picture

sproets commented

Yep, here the same issues :(

zebda’s picture

zebda commented

+1, I replaced beta 2 with beta 1 and everything is working again.

ddiestra’s picture

ddiestra commented
Status: Active » Needs review
StatusFileSize
new 3043003-issue-with-class.diff389 bytes

I found the issue, this line is missing use Drupal\Core\Entity\ContentEntityInterface. Added a patch with the fix.

ccshannon’s picture

ccshannon commented

Thanks, @ddiestra! This fixes the issue for me.

zebda’s picture

zebda commented

Thanks, that did the trick.

zanvidmar’s picture

zanvidmar commented

I can also confirm that #4 fixed the issue. Thank you.

afsch’s picture

afsch
Location Otavalo
commented

The fix in #4 should be applied as soon as possible. Thanks.

marassa’s picture

marassa commented

After update to beta2 my pager's prev link was pointing to the last record and the next link to the first record, and the log was full of
Notice: Undefined variable: entity in Drupal\entity_pager\EntityPager->getEntity() (line 108 of /home/ibeoomaj/public_html/modules/entity_pager/src/EntityPager.php)
errors. The patch #4 fixed that, thanks a ton!

marassa’s picture

marassa commented
Status: Needs review » Reviewed & tested by the community
stevieb’s picture

stevieb commented

Patch in #4 works

paperscenery’s picture

paperscenery commented

Thanks @ccshannon for posting this question—I thought I was losing my mind too. Patch in #4 fixed it. Thank you @ddiestra!

replicaobscura’s picture

replicaobscura
she/her
Primary language English
Location West Virginia
commented

Thanks for catching this issue, and posting the patch! Sorry for introducing this in the last update, I'll get this patch committed now.

replicaobscura’s picture

replicaobscura
she/her
Primary language English
Location West Virginia
commented

  • bmcclure committed 1e774a0 on 8.x-1.x authored by ddiestra 
    Issue #3043003 by ddiestra, ccshannon, marassa: Pager not correctly...
replicaobscura’s picture

replicaobscura
she/her
Primary language English
Location West Virginia
commented
Status: Reviewed & tested by the community » Fixed

I'm making a bug fix release for this issue now as well.

replicaobscura’s picture

replicaobscura
she/her
Primary language English
Location West Virginia
commented
Priority: Normal » Major

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.