Drupal 9 Deprecated Code Report [#3042953]

Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/cloudflare 288657c92dfed1217a06d8476190f2a945025c2a
source : http://cgit.drupalcode.org/cloudflare


 ------ --------------------------------------------------------------------- 
  Line   modules/cloudflarepurger/tests/src/Unit/CredentialTestCheckTest.php  
 ------ --------------------------------------------------------------------- 
  28     Call to deprecated method getMock() of class                         
         Drupal\Tests\UnitTestCase.                                           
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   modules/cloudflarepurger/tests/src/Unit/DiagnosticCheckTestBase.php  
 ------ --------------------------------------------------------------------- 
  67     Call to deprecated method getMock() of class                         
         Drupal\Tests\UnitTestCase.                                           
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/SettingsForm.php                          
 ------ --------------------------------------------------- 
  161    Call to deprecated function drupal_set_message().  
  233    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/ZoneSelectionForm.php                     
 ------ --------------------------------------------------- 
  113    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------------------- 
  Line   tests/src/Functional/CloudFlareAdminSettingsFormTest.php  
 ------ ---------------------------------------------------------- 
  55     Call to deprecated method assertUrl() of class            
         Drupal\Tests\BrowserTestBase.                             
  57     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  58     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  59     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  74     Call to deprecated method assertUrl() of class            
         Drupal\Tests\BrowserTestBase.                             
  76     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  77     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  101    Call to deprecated method assertText() of class           
         Drupal\Tests\BrowserTestBase.                             
  116    Call to deprecated method assertText() of class           
         Drupal\Tests\BrowserTestBase.                             
  130    Call to deprecated method assertText() of class           
         Drupal\Tests\BrowserTestBase.                             
 ------ ---------------------------------------------------------- 

 ------ ----------------------------------------------------------------- 
  Line   tests/src/Functional/CloudFlareAdminSettingsInvalidFormTest.php  
 ------ ----------------------------------------------------------------- 
  52     Call to deprecated method assertText() of class                  
         Drupal\Tests\BrowserTestBase.                                    
  53     Call to deprecated method assertField() of class                 
         Drupal\Tests\BrowserTestBase.                                    
  54     Call to deprecated method assertField() of class                 
         Drupal\Tests\BrowserTestBase.                                    
  55     Call to deprecated method assertField() of class                 
         Drupal\Tests\BrowserTestBase.                                    
  56     Call to deprecated method assertField() of class                 
         Drupal\Tests\BrowserTestBase.                                    
  67     Call to deprecated method assertResponse() of class              
         Drupal\Tests\BrowserTestBase.                                    
  94     Call to deprecated method assertUrl() of class                   
         Drupal\Tests\BrowserTestBase.                                    
  109    Call to deprecated method assertText() of class                  
         Drupal\Tests\BrowserTestBase.                                    
  124    Call to deprecated method assertText() of class                  
         Drupal\Tests\BrowserTestBase.                                    
  139    Call to deprecated method assertText() of class                  
         Drupal\Tests\BrowserTestBase.                                    
 ------ ----------------------------------------------------------------- 

 ------ -------------------------------------------------- 
  Line   tests/src/Functional/ComposerDependencyTest.php   
 ------ -------------------------------------------------- 
  48     Call to deprecated method assertRaw() of class    
         Drupal\Tests\BrowserTestBase.                     
  57     Call to deprecated method assertNoRaw() of class  
         Drupal\Tests\BrowserTestBase.                     
 ------ -------------------------------------------------- 

 ------ ---------------------------------------------- 
  Line   tests/src/Unit/ClientIpRestoreTest.php        
 ------ ---------------------------------------------- 
  36     Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
  67     Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
  80     Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
  122    Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
  127    Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
 ------ ---------------------------------------------- 

 [ERROR] Found 32 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#14	drupal_9_deprecated_code-3042953-14.patch	1.03 KB	jcnventura
#9	interdiff-4-9.txt	342 bytes	suzymasri
#9	drupal_9_deprecated_code-3042953-9.patch	14.26 KB	suzymasri
#4	drupal_9_deprecated_code-3042953-4.patch	13.93 KB	Sergiu Stici
#2	drupal_9_deprecated_code-3042953-2.patch	13.08 KB	Sergiu Stici

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

24 March 2019 at 17:15

mcdwayne created an issue. See original summary.

Comment #2

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented 22 April 2019 at 07:12

Status:

Active

» Needs review

File	Size
drupal_9_deprecated_code-3042953-2.patch	13.08 KB

Here is the patch, please review.

Comment #3

22 April 2019 at 07:18

Status:

Needs review

» Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3042953-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #4

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented 22 April 2019 at 07:31

Status:

Needs work

» Needs review

File	Size
drupal_9_deprecated_code-3042953-4.patch	13.93 KB

1 file was hidden/shown/deleted

File	Size
drupal_9_deprecated_code-3042953-2.patch	13.08 KB

Corrected codesniffer.

Comment #5

vijaycs85

London, UK

CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented 23 April 2019 at 06:34

Status:

Needs review

» Reviewed & tested by the community

Looks good.

Comment #6

Luke.Leber

English

Pennsylvania

CreditAttribution: Luke.Leber as a volunteer commented 28 April 2019 at 14:40

These changes look ok. We are quite excited to scratch another module off the D9 migration blockers list :-)

Comment #7

vijaycs85

London, UK

CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented 2 May 2019 at 13:05

just for updates: I have been trying to test the fixes locally and found problems with the latest version of drupal-check(see here for more details). Will commit once confirmed locally.

Comment #8

jmoreira CreditAttribution: jmoreira at Acquia commented 31 March 2020 at 18:37

Patch #4 works for me too. Any plans to get this in?

Comment #9

suzymasri

Greece

CreditAttribution: suzymasri at Pfizer, Inc. commented 14 April 2020 at 13:57

File	Size
drupal_9_deprecated_code-3042953-9.patch	14.26 KB
interdiff-4-9.txt	342 bytes

Patch #4 fixes all drupal-check reported errors. I just added the `core_version_requirement` key, patch attached.

This was tested with Drupal Check 1.1.1 and issue in #7 is resolved too.

Comment #10

27 April 2020 at 11:26

vijaycs85 committed f3d8ed0 on 8.x-1.x

Issue #3042953 by Sergiu Stici, suzymasri, mcdwayne, vijaycs85, Luke....

Comment #11

vijaycs85

London, UK

CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented 27 April 2020 at 11:27

Looks good. pushed in. Will cut a new release shortly.

Comment #12

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 12 May 2020 at 17:17

Status:

Reviewed & tested by the community

» Fixed

Comment #13

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 12 May 2020 at 17:19

Status:

Fixed

» Active

And active again because the cloudflarepurger submodule needs this line as well:

core_version_requirement: ^8 || ^9

Comment #14

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 12 May 2020 at 18:31

Status:

Active

» Needs review

File	Size
drupal_9_deprecated_code-3042953-14.patch	1.03 KB

Comment #15

24 May 2020 at 20:55

vijaycs85 committed 9aa28e5 on 8.x-1.x authored by jcnventura

Issue #3042953 by jcnventura: Drupal 9 Deprecated Code Report

Comment #16

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented 25 May 2020 at 07:13

Status:

Needs review

» Fixed

Comment #17

8 June 2020 at 07:14

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 Deprecated Code Report

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Referenced by

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community