Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/cloudflare 288657c92dfed1217a06d8476190f2a945025c2a
source : http://cgit.drupalcode.org/cloudflare 


 ------ --------------------------------------------------------------------- 
  Line   modules/cloudflarepurger/tests/src/Unit/CredentialTestCheckTest.php  
 ------ --------------------------------------------------------------------- 
  28     Call to deprecated method getMock() of class                         
         Drupal\Tests\UnitTestCase.                                           
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   modules/cloudflarepurger/tests/src/Unit/DiagnosticCheckTestBase.php  
 ------ --------------------------------------------------------------------- 
  67     Call to deprecated method getMock() of class                         
         Drupal\Tests\UnitTestCase.                                           
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/SettingsForm.php                          
 ------ --------------------------------------------------- 
  161    Call to deprecated function drupal_set_message().  
  233    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/ZoneSelectionForm.php                     
 ------ --------------------------------------------------- 
  113    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------------------- 
  Line   tests/src/Functional/CloudFlareAdminSettingsFormTest.php  
 ------ ---------------------------------------------------------- 
  55     Call to deprecated method assertUrl() of class            
         Drupal\Tests\BrowserTestBase.                             
  57     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  58     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  59     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  74     Call to deprecated method assertUrl() of class            
         Drupal\Tests\BrowserTestBase.                             
  76     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  77     Call to deprecated method assertRaw() of class            
         Drupal\Tests\BrowserTestBase.                             
  101    Call to deprecated method assertText() of class           
         Drupal\Tests\BrowserTestBase.                             
  116    Call to deprecated method assertText() of class           
         Drupal\Tests\BrowserTestBase.                             
  130    Call to deprecated method assertText() of class           
         Drupal\Tests\BrowserTestBase.                             
 ------ ---------------------------------------------------------- 

 ------ ----------------------------------------------------------------- 
  Line   tests/src/Functional/CloudFlareAdminSettingsInvalidFormTest.php  
 ------ ----------------------------------------------------------------- 
  52     Call to deprecated method assertText() of class                  
         Drupal\Tests\BrowserTestBase.                                    
  53     Call to deprecated method assertField() of class                 
         Drupal\Tests\BrowserTestBase.                                    
  54     Call to deprecated method assertField() of class                 
         Drupal\Tests\BrowserTestBase.                                    
  55     Call to deprecated method assertField() of class                 
         Drupal\Tests\BrowserTestBase.                                    
  56     Call to deprecated method assertField() of class                 
         Drupal\Tests\BrowserTestBase.                                    
  67     Call to deprecated method assertResponse() of class              
         Drupal\Tests\BrowserTestBase.                                    
  94     Call to deprecated method assertUrl() of class                   
         Drupal\Tests\BrowserTestBase.                                    
  109    Call to deprecated method assertText() of class                  
         Drupal\Tests\BrowserTestBase.                                    
  124    Call to deprecated method assertText() of class                  
         Drupal\Tests\BrowserTestBase.                                    
  139    Call to deprecated method assertText() of class                  
         Drupal\Tests\BrowserTestBase.                                    
 ------ ----------------------------------------------------------------- 

 ------ -------------------------------------------------- 
  Line   tests/src/Functional/ComposerDependencyTest.php   
 ------ -------------------------------------------------- 
  48     Call to deprecated method assertRaw() of class    
         Drupal\Tests\BrowserTestBase.                     
  57     Call to deprecated method assertNoRaw() of class  
         Drupal\Tests\BrowserTestBase.                     
 ------ -------------------------------------------------- 

 ------ ---------------------------------------------- 
  Line   tests/src/Unit/ClientIpRestoreTest.php        
 ------ ---------------------------------------------- 
  36     Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
  67     Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
  80     Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
  122    Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
  127    Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
 ------ ---------------------------------------------- 

 [ERROR] Found 32 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 drupal_9_deprecated_code-3042953-14.patch1.03 KBjcnventura
#9 interdiff-4-9.txt342 bytessuzymasri
#9 drupal_9_deprecated_code-3042953-9.patch14.26 KBsuzymasri
#4 drupal_9_deprecated_code-3042953-4.patch13.93 KBsergiu stici
#2 drupal_9_deprecated_code-3042953-2.patch13.08 KBsergiu stici

Comments

mcdwayne created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042953-2.patch13.08 KB

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3042953-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

sergiu stici’s picture

sergiu stici commented
Status: Needs work » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042953-4.patch13.93 KB

Corrected codesniffer.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented

These changes look ok. We are quite excited to scratch another module off the D9 migration blockers list :-)

vijaycs85’s picture

vijaycs85
Location London, UK
commented

just for updates: I have been trying to test the fixes locally and found problems with the latest version of drupal-check(see here for more details). Will commit once confirmed locally.

jmoreira’s picture

jmoreira commented

Patch #4 works for me too. Any plans to get this in?

suzymasri’s picture

suzymasri
Location Greece
commented
StatusFileSize
new drupal_9_deprecated_code-3042953-9.patch14.26 KB
new interdiff-4-9.txt342 bytes

Patch #4 fixes all drupal-check reported errors. I just added the `core_version_requirement` key, patch attached.

This was tested with Drupal Check 1.1.1 and issue in #7 is resolved too.

  • vijaycs85 committed f3d8ed0 on 8.x-1.x 
    Issue #3042953 by Sergiu Stici, suzymasri, mcdwayne, vijaycs85, Luke....
vijaycs85’s picture

vijaycs85
Location London, UK
commented

Looks good. pushed in. Will cut a new release shortly.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Fixed » Active

And active again because the cloudflarepurger submodule needs this line as well:

core_version_requirement: ^8 || ^9

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new drupal_9_deprecated_code-3042953-14.patch1.03 KB

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.