Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/fb_likebox 4190c1c30b675b9c9e2ede23d4858662b3bf50b3
source : http://cgit.drupalcode.org/fb_likebox

Pareview checklist:

https://pareview.sh/pareview/https-git.drupal.org-project-fb_likebox-8.x...

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 interdiff-3042950-5-6.txt1.8 KBnaveenvalecha
#6 3042950-7.patch2.06 KBnaveenvalecha
#5 3042950-fb-likebox-deprecated-code-5.patch544 bytessershevchyk

Comments

mcdwayne created an issue. See original summary.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Issue summary: View changes
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Issue summary: View changes
sershevchyk’s picture

sershevchyk
Primary language Ukrainian
Location Lutsk
commented

drupal-check modules/contrib/fb_likebox
3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ---------------------------------------------------------
Line src/Tests/FBLikeboxBlockTest.php
------ ---------------------------------------------------------
12 Class Drupal\fb_likebox\Tests\FBLikeboxBlockTest extends deprecated class Drupal\simpletest\WebTestBase:
in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
25 Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
------ ---------------------------------------------------------

[ERROR] Found 2 errors

sershevchyk’s picture

sershevchyk
Primary language Ukrainian
Location Lutsk
commented
Status: Active » Needs review
StatusFileSize
new 3042950-fb-likebox-deprecated-code-5.patch544 bytes
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Drupal 9 Deprecated Code Report » Make the Module ready for Drupal 9
StatusFileSize
new 3042950-7.patch2.06 KB
new interdiff-3042950-5-6.txt1.8 KB

  • naveenvalecha committed cd32310 on 8.x-2.x 
    Issue #3042950 by naveenvalecha, SerShevchyk, vuil: Make the Module...
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Fixed

The Patch is green. Committed to 8.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented

I added my current employer!

akram zairig’s picture

akram zairig commented

This patch is not working :/

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented

This was committed here in #7, so no need for the patch, just need to use the dev version to run in D9.

Would be really good to get a new release cut.

Coops_’s picture

Coops_
Location London
commented

+1 for getting a tagged release for this for D9